Opened 11 years ago

Closed 11 years ago

#3928 closed Enhancement (fixed)

Update blocklist download to handle archives (including ZIP)

Reported by: evands Owned by: livings124
Priority: Normal Milestone: 2.20
Component: Mac Client Version: 2.13
Severity: Normal Keywords:
Cc:

Description

Currently, the blocklist URL download system chokes if it receives a ZIP file. I think it also chokes if given certain encoded files (e.g. macbinary) but I didn't double-check that.

The attached patch uses unzip automatically as necessary, maintains the server-provided filename to provide the best chance of NSURLDownload automatically decoding the file, and explicitly uses the delegate callback to request that decoding happen as necessary.

The most obvious result - and the itch I was scratching - is that http://list.iblocklist.com/?list=bt_level1 is now a valid URL from which to autoupdate the blocklist.

Attachments (1)

blocklist-url-zip-handling.diff (4.6 KB) - added by evands 11 years ago.
Patch against [11737]

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by evands

Patch against [11737]

comment:1 Changed 11 years ago by livings124

  • Milestone changed from None Set to 2.20
  • Summary changed from Fixed blocklist download to handle archives (including ZIP) [Patch Mac OS X] to Update blocklist download to handle archives (including ZIP)
  • Type changed from Bug to Enhancement

comment:2 Changed 11 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed

Thanks! I've used your patch (with some style/consistency changes) in r11765.

Note: See TracTickets for help on using tickets.