Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#3939 closed Bug (fixed)

autogen.sh doesn't work correctly on systems where /bin/sh doesn't point to bash

Reported by: er13 Owned by: er13
Priority: Normal Milestone:
Component: Transmission Version: 2.13+
Severity: Normal Keywords: backport-2.0x backport-2.1x
Cc:

Description

autogen.sh uses [[, which is a bashism. Either change the shebang line to #!/bin/bash or apply the following patch

  • autogen.sh

     
    2424
    2525./update-version-h.sh
    2626
    27 autoreconf -fi
    28 if [[ $? -ne 0 ]]; then
    29   exit 1
    30 fi
     27autoreconf -fi || exit 1
    3128

Change History (4)

comment:1 Changed 7 years ago by jordan

  • Milestone None Set deleted
  • Owner set to jordan
  • Status changed from new to assigned

thanks for the patch!

comment:2 Changed 7 years ago by jordan

  • Owner changed from jordan to er13
  • Status changed from assigned to new

comment:3 Changed 7 years ago by jordan

  • Resolution set to fixed
  • Status changed from new to closed

r11753 /trunk/autogen.sh:

#3939 "autogen.sh doesn't work correctly on systems where /bin/sh doesn't point to bash" -- fixed with patch from er13

This bug was introduced a couple of days ago in the fix to #3901 "Confusing error message when libtool is missing." The fix introduced a bashism, which should be avoided if we want to work with strict sh.

comment:4 Changed 7 years ago by jordan

  • Keywords backport-2.0x backport-2.1x added
Note: See TracTickets for help on using tickets.