Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3952 closed Enhancement (fixed)

memory cache should use evbuffers to avoid unnecessary mallocs/memcpys

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.20
Component: libtransmission Version: 2.13
Severity: Minor Keywords:
Cc:

Description

both peer-msgs and webseed use evbuffers internally, and those buffers' contents are memdup'ed when added to the memory cache.

If the memory cache used evbuffers as well, we could use evbuffer_remove_buffer() to avoid unnecessary memcpys.

Attachments (1)

cache-buf.diff (4.4 KB) - added by jordan 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by jordan

comment:1 Changed 11 years ago by jordan

  • Owner set to jordan
  • Status changed from new to assigned
  • Summary changed from use evbuffer in libtransmission's memory cache to avoid excess malloc/memcpy to memory cache should use evbuffers to avoid unnecessary mallocs/memcpys

comment:2 in reply to: ↑ description Changed 11 years ago by patioheater12

(spam removed)

Last edited 11 years ago by jordan (previous) (diff)

comment:3 Changed 11 years ago by jordan

  • Milestone changed from 2.30 to 2.21

comment:4 Changed 11 years ago by jordan

  • Milestone changed from 2.21 to 2.20

Promoting to 2.20 for a third beta, based on feedback from the other transmission devs

comment:5 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

r11782 -- added.

comment:6 Changed 11 years ago by jordan

  • Component changed from Transmission to libtransmission
Note: See TracTickets for help on using tickets.