Opened 11 years ago

Closed 11 years ago

#3969 closed Enhancement (fixed)

tr_base64_encode() has unnecessary overhead with linefeeds

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.20
Component: libtransmission Version: 2.13
Severity: Minor Keywords:


tr_base64_encode() generates strings that include linefeeds. The strings will be slightly shorter if we use BIO_set_flags( b64, BIO_FLAGS_BASE64_NO_NL ) to disable the unnecessary linefeeds.

Change History (2)

comment:1 Changed 11 years ago by jordan

  • Milestone changed from None Set to 2.20
  • Status changed from new to assigned

comment:2 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

jordan * r11798 libtransmission/ (utils-test.c utils.c):

(trunk libT) #3969 "tr_base64_encode() has unnecessary overhead with linefeeds" -- fixed.

Don't add linefeeds to base64-encoded data. We don't need it and it just increases the length of the string, which is typically sent over the network to an RPC client.

Note: See TracTickets for help on using tickets.