Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3971 closed Bug (fixed)

favicons do not work for ip addresses

Reported by: ijuxda Owned by: jordan
Priority: Normal Milestone: 2.20
Component: GTK+ Client Version: 2.13
Severity: Minor Keywords: favicon tracker ip address
Cc:

Description

If the tracker announce url contains an IP address rather than a hostname, the favicon never shows up.

Change History (3)

comment:1 Changed 11 years ago by jordan

  • Status changed from new to assigned
  • Version changed from 2.13+ to 2.13

Fixed for cases where the IP address actually has a favicon.{ico,png,jpg,gif}.

This still fails in some cases such as publicbt.com, since publicbt.com/favicon.ico exists, but tracker.publicbt.com/favicon.ico does not exist. For that we would need to do a reverse lookup to get "tracker.publicbt.com" and from there jump to publicbt.com...

comment:2 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

jordan * r11801 gtk/ (filter.c util.c):

(trunk gtk) #3971 "favicons do not work for IP addresses" -- fixed.

gtr_get_host_from_url() wasn't written to handle dotted-quad or IPv6 address strings, but can handle them now.

comment:3 Changed 11 years ago by jordan

  • Milestone changed from None Set to 2.20
Note: See TracTickets for help on using tickets.