Opened 11 years ago

Closed 11 years ago

#3974 closed Bug (duplicate)

Additional requests not cancelled when block complete

Reported by: harrydb Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.13
Severity: Normal Keywords: endgame, requestcount
Cc:

Description

In the endgame multiple peers can be request the same block. When one finishes the other requests should be canceled but this currently does not happen in transmission causing unneeded overhead.

This also causes Torrent.requestCount to be unusable in the endgame as its number is higher than the number of requests that actually matter.

Change History (4)

comment:1 Changed 11 years ago by harrydb

  • Summary changed from Additional downloads not cancelled when block complete to Additional requests not cancelled when block complete

comment:2 Changed 11 years ago by jordan

harrydb, your endgame patch is looking pretty good, do you want to cook up a patch for this ticket too?

comment:3 Changed 11 years ago by harrydb

Actually I just posted a fourth patch for the endgame which also fixes this, but it does use a function that is not in the current code so it cannot be applied without the rest of that patch. We can close this one when that one goes in or take it as a part of that one and close now. I created a separate ticket because it exists with the current endgame code as well.

comment:4 Changed 11 years ago by jordan

  • Resolution set to duplicate
  • Status changed from new to closed

I agree with all of that. Fortunately #3656's summary ("Endgame could be faster") is broad enough to encompass this issue too... ;)

Closing this ticket as a subset of #3656

Note: See TracTickets for help on using tickets.