Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#3993 closed Bug (fixed)

Version (-V) option no longer outputs svn revision no.

Reported by: gunzip Owned by:
Priority: Low Milestone: 2.21
Component: Transmission Version: 2.20
Severity: Minor Keywords:
Cc:

Description

when issuing "transmission-remote -V" or "transmission-daemon -V" from command line response is now

transmission-daemon 2.20b4 (2011-02-02)
or
transmission-daemon 2.20 (2011-02-02)

when in past output would, for example, give "transmission-daemon 2.12 (10237)" which is more useful for distinguishing builds especially when one is regularly testing the nightlies. the (date) is rather ambiguous.

Change History (8)

comment:1 follow-up: Changed 11 years ago by jordan

  • Resolution set to worksforme
  • Status changed from new to closed

Nothing has changed -- when you build from an svn snapshot, you'll get the build number. When you build from a tarball, the svn information isn't there, so it's not included in version.h. For example here's a build I did from svn earlier today:

$ ./transmission-remote -V
transmission-remote 2.20+ (11842)

comment:2 in reply to: ↑ 1 Changed 11 years ago by gunzip

Replying to jordan:

Nothing has changed -- when you build from an svn snapshot, you'll get the build number. When you build from a tarball, the svn information isn't there, so it's not included in version.h.

OK, but nevertheless in past i've always compiled ( many, many times) from the tarballs at https://build.transmissionbt.com/job/trunk-linux/ and i always got the revision no. with the -V option. it's only recently that i see the (date) thing which so far is stuck at 2011-02-02.

comment:3 Changed 11 years ago by ijuxda

Could this be because update-version-h.sh was not called prior to the creation of the tarball?

comment:4 Changed 11 years ago by jordan

  • Resolution worksforme deleted
  • Status changed from closed to reopened

the tarball won't build if update-version-h.sh isn't called, since a missing version.h will cause "make distcheck" to fail.

My guess is that the call to awk in update-version-h.sh isn't getting the input it expects. I'll dig into that theory a little bit...

comment:5 Changed 11 years ago by jordan

  • Milestone changed from None Set to 2.21
  • Severity changed from Normal to Minor

Sure enough.

Sorry for closing the ticket too hastily, gunzip :)

comment:6 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

jordan * r11852 libtransmission/ (tr-dht.c tr-dht.h):

(trunk libT) #3993 "Version (-V) option no longer outputs svn revision no." -- fixed.

update-version-h.sh tries to use svnversion when possible. But when it's not, it looks through the "$Id:" lines in the source file comments and uses the largest version number it finds. The new files tr-dht.[ch] didn't have the line of its $Id: comment formatted in the way update-version-h.sh expected. tr-dht.[ch]'s $Id: line has been homogenized to be like everyone else's...

comment:7 Changed 11 years ago by gunzip

yes all is good now

$ transmission-daemon -V
transmission-daemon 2.20+ (11852)

comment:8 Changed 11 years ago by jordan

Thanks for the confirmation gunzip :)

Note: See TracTickets for help on using tickets.