Opened 11 years ago

Closed 11 years ago

Last modified 11 years ago

#4024 closed Bug (fixed)

blocklist code doesn't handle overlapping / unsorted rules

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.22
Component: libtransmission Version: 2.20
Severity: Normal Keywords:
Cc:

Description (last modified by jordan)

For example, consider these rules from a blocklist:

:24.142.0.0-24.142.95.255
:24.142.5.0-24.142.5.255
:24.142.75.0-24.142.75.255

The last two lines are subsets of the first one. This is a problem, since Transmission assumes the rules are sorted in ascending order and don't overlap, so that we can do a binary search on them.

This appears to be common enough in practice that Transmission needs to be able to sort & merge the rulesets.

Change History (4)

comment:1 Changed 11 years ago by jordan

  • Status changed from new to assigned

comment:2 Changed 11 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed
  • Summary changed from blocklist implementation doesn't handle overlapping / unsorted rule sets to blocklist code doesn't handle overlapping / unsorted rules

fixed in r11888.

comment:3 Changed 11 years ago by jordan

  • Description modified (diff)

comment:4 Changed 11 years ago by jordan

backported to 2.2x branch in r12024

Note: See TracTickets for help on using tickets.