Opened 11 years ago

Closed 11 years ago

#4068 closed Enhancement (wontfix)

Give users more information when a torrent is a duplicate

Reported by: jordan Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.20
Severity: Normal Keywords:
Cc:

Description

Periodically users will complain that they get a "can't add duplicate torrent" and not know why. Sometimes this is human error because the user has that torrent filtered out of the display, but sometimes it's because there's a duplicate torrent with a different name.

If tr_torrentNew() or tr_torrentParse() find a duplicate torrent, rather than returning an "ERR_DUP" enum value, it should give the ID of the duplicate torrent so that the client application can provide the user with more information.

Attached is a draft version of this.

livings, if you want to crib the basic flow from one of the other clients, I'd recommend you look at the patch for daemon.c... adding torrents in the GTK+ client is a rat's nest of hacks.

Attachments (1)

duplicate-01.diff (22.0 KB) - added by jordan 11 years ago.
1st revision of the patch

Download all attachments as: .zip

Change History (3)

Changed 11 years ago by jordan

1st revision of the patch

comment:1 Changed 11 years ago by livings124

I'm not really a fan of this, as we discussed on IRC. The majority of times there's a duplicate (in my experience at least) with the same name or because the transfer has been removed from the ui but still exists in libT. This patch just makes the code more complex.

comment:2 Changed 11 years ago by livings124

  • Resolution set to wontfix
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.