Opened 10 years ago

Closed 10 years ago

#4215 closed Bug (fixed)

bug in unchoking algorithm

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.30
Component: libtransmission Version: 2.21
Severity: Normal Keywords: backport-2.2x
Cc:

Description

In peer-mgr.c's rechokeDownloads() code, we make a temporary duplicate of the array of tr_peer pointers so that we can randomize it.

Unfortunately we keep reading from the original array instead of the temporary duplicate. :|

This isn't terrible, but it does mean we lose the advantages of randomization. It also means there is a chance some peers won't get unchoked even if they deserve to be.

Change History (2)

comment:1 Changed 10 years ago by jordan

  • Keywords backport-2.2x added
  • Status changed from new to assigned

Fixed in trunk by r12401.

comment:2 Changed 10 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.