Changes between Initial Version and Version 1 of Ticket #4329, comment 2


Ignore:
Timestamp:
May 10, 2012, 6:13:30 PM (10 years ago)
Author:
gvdl
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #4329, comment 2

    initial v1  
    1 I have traced the code. The code path is correct, once the daemon is up and saves the given config directory in the session at sessionInit time. Then this configDir is used later when a SIGHUP is received. So there is no apparent problem in the average save. I also checked that setConfigDir is only called in one place and I couldn't find any other areas where session->configDir is being set so the code seems to be clean. Now there is a magic bit of code that says, if the configDir is NULL then return the default directory. But this would be a different big, some part of the code would be scribbling over the session structure and that would be bad! There is a race condition with the signal handling during initialisation of the daemon, but I'll raise another bug for that.
     1I have traced the code. The code path is correct, once the daemon is up and saves the given config directory in the session at sessionInit time. Then this configDir is used later when a SIGHUP is received. So there is no apparent problem in the average save. I also checked that setConfigDir is only called in one place and I couldn't find any other areas where session->configDir is being set so the code seems to be clean.
    22
    3 stillinbeta: Can you reproduce the bug with a long running (>10min) daemon?
     3Also there is a race condition with the signal handling during initialisation of the daemon, but I'll raise another bug for that.
     4
     5There is a magic bit of code that says, if the configDir is NULL then return the default directory. But this would be a different bug, some part of the code would be scribbling over the session structure and that would be bad!
     6
     7So stillinbeta Can you reproduce the bug with a long running (>10min) daemon? If so we may have a buffer overrun and I'd like to investigate that ASAP