Opened 10 years ago

Closed 10 years ago

#4360 closed Enhancement (fixed)

Warning when building Transmission on Mac because the delegate of TorrentTableView does not implement the protocol NSOutlineViewDelegate

Reported by: Benjamin Owned by: livings124
Priority: Lowest Milestone: 2.40
Component: Mac Client Version: 2.32
Severity: Trivial Keywords:
Cc:

Description

Fix one of the warning on mac: the delegate of TorrentTableView? does not implement NSOutlineViewDelegate.

This is more to find how to contribute patches than a serious bug :)

Attachments (1)

sl_delegate_protocol.patch (436 bytes) - added by Benjamin 10 years ago.
Patch

Download all attachments as: .zip

Change History (7)

comment:1 follow-up: Changed 10 years ago by livings124

Thanks for the patch! Since the code can only be compiled on 10.6 anyways, the #if, etc. wouldn't be needed.

comment:2 in reply to: ↑ 1 Changed 10 years ago by Benjamin

Replying to livings124:

Thanks for the patch! Since the code can only be compiled on 10.6 anyways, the #if, etc. wouldn't be needed.

Don't you support 10.5? I assumed you support building on the 10.5 SDK where those protocols would not be defined.

comment:3 Changed 10 years ago by livings124

10.5 is supported in terms of running the app, but we only support building with the 10.6 SDK.

comment:4 Changed 10 years ago by jordan

But it would run on 10.5 anyway, even after being built with 10.6 symbols?

comment:5 Changed 10 years ago by livings124

Yup, since I check at run-time before doing anything 10.6-only. Objective-C is nice like that.

Changed 10 years ago by Benjamin

Patch

comment:6 Changed 10 years ago by livings124

  • Milestone changed from None Set to 2.40
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.