Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#4399 closed Enhancement (fixed)

Add option to disable "Trash Can" feature

Reported by: bizi Owned by: jordan
Priority: Normal Milestone: 2.40
Component: GTK+ Client Version: 2.33
Severity: Normal Keywords:
Cc:

Description (last modified by jordan)

Hi,

Didn't know about this bug reporting tool so I made a post here about a problem and bug, bug meaning as it relates to affecting a file manager;

https://forum.transmissionbt.com/viewtopic.php?f=9&t=12007

Thank you...

I'm running Slackware with only OpenBox? as my desktop and I just noticed the other day when deleting a torrent by right clicking on it, 'Delete Files and Remove', that the path, ~/.local/share/Trash is being created. Well this wouldn't be such a problem if everything being placed there was actually deleted at some point, but instead it just keeps filling up.

I also use a file manger called PCManFM-Mod which is a modified version of the legacy PCMan File Manager v0.5.2 and it does not have trash support, so when you delete something it gets deleted. But for some odd reason, now with Tranmssion making this trash path I noticed the file manager no longer deleting, but also placing everything into this path.

So now Tranmssions keeps dumping into this path filling it up and so does this filemanager, which it shouldn't be doing this, a bug I'll have to report over Transmission affecting the file manger behaviour.

This is a bit of a pain, now a two step process, deleting something, then needing to go to this path and delete it again...

I also noticed in the preferences under the Torrents tab section, 'Move .torrent file to trash', again the behaviour I would not want, since OpenBox?, nor PCManFM-Mod do not have any Trash features/options...

I had a look at the source, ./configure --help and noticed no options for disabling this trash feature.

I hope some of the Transmission developers will see this and please make an option for those that wish to disable this trash path along with the 'Move .torrrent file to trash', so that these things are simply deleted.

For the source, I guess making an option --disable-trash and in the preferences two options;

'Move .torrent file to trash' 'Delete .torrent file'

Thank you...

Change History (19)

comment:1 Changed 10 years ago by jordan

  • Description modified (diff)

comment:2 Changed 10 years ago by jordan

  • Type changed from Bug to Enhancement

comment:3 Changed 10 years ago by jordan

  • Milestone changed from None Set to Sometime

comment:4 Changed 10 years ago by jordan

  • Milestone changed from Sometime to 2.40
  • Status changed from new to assigned

comment:5 Changed 10 years ago by jordan

  • Summary changed from ~/.local/share/Trash Being Created & Affecting File Managers to Add option to disable "Trash Can" feature

comment:6 Changed 10 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Added in r12682

comment:7 Changed 8 years ago by TransBT

Hello,

Three years later I still have this problem, I'm now using 2.82

I see the last comment;

Resolution set to fixed Status changed from assigned to closed

Added in r12682

But where is the fix for this, I don't see any options other than under the Downloading tab;

move .torrent file to trash

I also do not see any compile options to remove this trash feature.

In 2.82 I just right clicked on a torrent and clicked;

Delete Files and Remove

And this just created these /paths;

/.local/share/Trash ls files info

If this has been fixed how do I stop this?

Thank you...

comment:8 Changed 8 years ago by TransBT

  • Priority changed from Normal to High
  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Version changed from 2.33 to 2.82

comment:9 Changed 8 years ago by livings124

  • Milestone changed from 2.40 to None Set
  • Priority changed from High to Normal
  • Version changed from 2.82 to 2.33

comment:10 Changed 8 years ago by TransBT

Why was the ticket changed back to version 2.33 when it's still an issue in the latest version, and if it's not can someone tell me how to make it stop creating the Trash directory?

Thank you...

comment:11 Changed 8 years ago by livings124

If the ticket's open it affects the current version; otherwise, every single open ticket would have the same version number and have to be updated each release. The Version field is to know when it originated.

comment:12 Changed 8 years ago by TransBT

Ok thanks you very much for a heads up on this...

Can someone please get back to me as soon as possible to let me know why it was said it was fixed when it wasn't?

I just can't believe 3 years later we still have this problem...

thanks...

comment:13 Changed 8 years ago by TransBT

Can someone please tell me was this suppose to of been fixed 3 years ago as this report seems to of indicated?

thank you...

comment:14 Changed 8 years ago by x190

TransBT, can you compile the source code yourself? Have you gone through the options to see if this is configurable?

Last edited 8 years ago by x190 (previous) (diff)

comment:15 Changed 8 years ago by TransBT

I mentioned when I posted this 3 years ago I was looking at the source, sorry I thought I mentioned I compiled this.

But I'm not using the QT version because I believe the latest Transmission requires QT5 and Slack only has QT4 so I'm only using the GTK version.

So it's the same thing as before, I compiled this from source and the configure options show nothing about any Trash features, and when looking through Transmissions preferences I don't see any features either, again for the GTK client.

Here's the configure options;

http://dpaste.com/1599BGP/

comment:16 Changed 8 years ago by x190

trunk/gtk/conf.c Line 85:

-tr_variantDictAddBool (d, TR_KEY_trash_can_enabled, TRUE); +tr_variantDictAddBool (d, TR_KEY_trash_can_enabled, FALSE);

comment:17 follow-up: Changed 8 years ago by jordan

  • Milestone changed from None Set to 2.40
  • Resolution set to fixed
  • Status changed from reopened to closed

TransBT, you can disable the trashcan option by setting "trash-can-enabled" to false in ~/.config/transmission/settings.json

comment:18 in reply to: ↑ 17 Changed 8 years ago by x190

Replying to jordan:

TransBT, you can disable the trashcan option by setting "trash-can-enabled" to false in ~/.config/transmission/settings.json

Please document this feature in https://trac.transmissionbt.com/wiki/EditConfigFiles.

comment:19 Changed 8 years ago by TransBT

Ok, I will do this for now, but I hope in a future version you'll give both the GKT & QT clients configure options to disable this like the examples below;

GTK --disable-trash

QT -DWITH_TRASH=OFF

thank you

Note: See TracTickets for help on using tickets.