Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#4421 closed Enhancement (fixed)

Fix the warnings related to missing protocols definition

Reported by: Benjamin Owned by: livings124
Priority: Lowest Milestone: 2.40
Component: Mac Client Version: 2.33
Severity: Trivial Keywords:
Cc:

Description

Fix the warnings related to missing protocols definition Warning count for compiling Transmission: 114 -> 95

Attachments (1)

fix_missing_protocol_warnings.patch (2.0 KB) - added by Benjamin 10 years ago.
Patch

Download all attachments as: .zip

Change History (3)

Changed 10 years ago by Benjamin

Patch

comment:1 follow-up: Changed 10 years ago by livings124

  • Milestone changed from None Set to 2.40
  • Resolution set to fixed
  • Status changed from new to closed

r12686

I included all but the NSComboBoxDataSource, since that doesn't appear to be correct.

comment:2 in reply to: ↑ 1 Changed 10 years ago by Benjamin

Replying to livings124:

r12686

I included all but the NSComboBoxDataSource, since that doesn't appear to be correct.

Indeed, I did not realize when writing but that one is pretty weird. The compiler is complaining about the following:

  • (void) beginPreviewPanelControl: (id) panel

{

fPreviewPanel = [panel retain]; [fPreviewPanel setDelegate: self]; [fPreviewPanel setDataSource: self];

}

It looks like the right type would be QLPreviewPanelDataSource, not NSComboBoxDataSource. Not sure why it mentioned NSComboBoxDataSource in the warnings.

Note: See TracTickets for help on using tickets.