On Mac, tr_getWebClientDir() uses incorrect encoding for creating the web content dir path

[Benjamin]

The code uses CFStringGetFastestEncoding() which does not always return a correct encoding when working with non-latin1 string (if the use uses a Asian username for example).

It should use CFStringGetFileSystemRepresentation() instead, which return string with the right encoding for system calls.

[Benjamin]

Patch

[livings124]

r12684 Thanks!

[Benjamin]

There was a reason for the UNUSED in the original patch. Without it, you will get a "unused variable" warning when building in release since the variable is only used in an assertion...

[livings124]

It's not unused when building in debug. A warning is better than marking a used variable unused.

[Benjamin]

Replying to livings124:

A warning is better than marking a used variable unused.

How so?

I am used to so many projects building with -Werror, all those warnings are kind of scary for me :-D

[livings124]

The compiler can do weird things if you give it bad/wrong code. Warnings are harmless.

[Benjamin]

Replying to livings124:

The compiler can do weird things if you give it bad/wrong code. Warnings are harmless.

hehe :-)

For some projects the policy is if the compiler and the static analyzer cannot assert what you do, then your code is not clear enough. No worries, I guess you just have a different culture in Transmission.

[livings124]

Feel free to update the code to mark is unused when it is. My policy is I'd rather have right code than warning-free code. Notice I even add my own warnings as reminders through the code. :)