Opened 9 years ago

Last modified 9 years ago

#4487 new Enhancement

make transmission.h match rpc-spec.txt

Reported by: reardon Owned by: jordan
Priority: Normal Milestone: None Set
Component: libtransmission Version: 2.33
Severity: Normal Keywords: rpc
Cc:

Description (last modified by jordan)

There are a few fields in tr_stat in transmission.h which do not match rpc-spec.txt

Not a life or death issue, but would be nice if they matched. Given the admonition in rpc-spec to look at transmission.h, it is thus an extension of the spec and should be cleaner.

[sorry, I'm sure you'd rather have the patch, just lazy at the moment]

so:

finished -> isFinished
ratio -> uploadRatio
pieceDownloadSpeed_KBps -> rateDownload
pieceUploadSpeed_KBps -> rateUpload

At a minimum, the comments in transmission.h for tr_stat should say what the RPC field is if it doesn't have the same name (though this is slightly dangerous for code maintainence, as the decision is ultimately made in rpcimpl.c). For instance, by looking at transmission.h I do not know which of the tr_stat fields maps to rateUp/Down.

Change History (3)

comment:1 Changed 9 years ago by jordan

  • Version changed from 2.33+ to 2.33

comment:2 Changed 9 years ago by jordan

  • Description modified (diff)

comment:3 Changed 9 years ago by jordan

  • Type changed from Bug to Enhancement
Note: See TracTickets for help on using tickets.