Opened 10 years ago
Last modified 6 years ago
#4518 assigned Enhancement
mark appropriate fields in prefs as html5 number fields
| Reported by: | livings124 | Owned by: | mike.dld |
|---|---|---|---|
| Priority: | Normal | Milestone: | Sometime |
| Component: | Web Client | Version: | 2.33 |
| Severity: | Normal | Keywords: | patch-needed |
| Cc: |
Description
There are multiple fields that only accept number values in the prefs window, so they should be marked as such (with the corresponding min and step).
Attachments (2)
Change History (13)
comment:1 Changed 8 years ago by jordan
- Keywords patch_needed added
comment:2 Changed 7 years ago by mike.dld
- Keywords patch-needed added; patch_needed removed
Changed 7 years ago by e-moe
comment:3 Changed 7 years ago by e-moe
See my attached file with changes for html5 input fields.
comment:4 Changed 7 years ago by e-moe
diff updated.
comment:5 Changed 7 years ago by livings124
You need to upload it with a different name.
comment:6 Changed 7 years ago by e-moe
done
comment:7 Changed 6 years ago by mike.dld
- Owner set to mike.dld
- Status changed from new to assigned
comment:8 Changed 6 years ago by mike.dld
What I don't like in this patch is that browsers add an error tooltip (and decorate the input field) if value is not a multiple of a step attribute. I would expect step to be applied when using up/down keys (or stepper arrows), but not be a part of validation...
comment:9 Changed 6 years ago by e-moe
We can remove step attribute and it's validation. If we need up/down keys working we will need to add custom java script logic. Let's split this task for two smaller ones: input type number with min/max values validation and second one - up/down keys. What do you think?
comment:10 Changed 6 years ago by mike.dld
Sounds good. I'll commit the first part later today.
comment:11 Changed 6 years ago by mike.dld
With a minor delay, r14570.
index.html diff for html5 input fields