Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#455 closed Bug (fixed)

double clicking torrent window no longer opens inspector on leopard

Reported by: jah Owned by: livings124
Priority: Normal Milestone: 1.01
Component: Mac Client Version: 0.93
Severity: Normal Keywords:
Cc:

Description

as the description says. latest svn

Attachments (1)

macosx.diff (2.7 KB) - added by Stick Men 14 years ago.
Suggested patch for fix

Download all attachments as: .zip

Change History (8)

comment:1 Changed 14 years ago by livings124

  • Component changed from Transmission to OS X Interface
  • Owner changed from somebody to livings124

comment:2 Changed 14 years ago by mickbuddha

this also effects double clicking torrent icons, which used to reveal in finder, and now does nothing

comment:3 follow-up: Changed 14 years ago by sanmarcos

  • Version changed from 0.92 to 0.93

I can confirm this with 0.93

Changed 14 years ago by Stick Men

Suggested patch for fix

comment:4 in reply to: ↑ 3 Changed 14 years ago by Stick Men

So, I read up a bit on MVC and that made things much clearer. Knowing that the events are all monitored using the Observer Pattern pretty much got me sorted out.

The problem lies in the TorrentTableView? class. The code for the double-click event resides in the mouseUp method, but this method never gets called when double-clicking on the TorrentCell?. By migrating most of the code from the mouseUp method to the mouseDown method everything works just fine.

I have not been able to find out why this behavior is different between Tiger and Leopard, however. Worse, I do not have a Tiger installation with which to test my fix, although it does work under Leopard.

I can post my diff if you like, but I imagine you can fix this yourself fairly easily. Of course, if I'm still totally off-base on this, let me know and I'll keep at it :)

comment:5 Changed 14 years ago by livings124

Could you submit a diff?

comment:6 Changed 14 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed

comment:7 Changed 14 years ago by livings124

  • Milestone changed from None Set to 1.01
Note: See TracTickets for help on using tickets.