#4553 closed Enhancement (fixed)
Set about dialog to modal when compiled with GTK+-3
| Reported by: | fmuellner | Owned by: | jordan |
|---|---|---|---|
| Priority: | Low | Milestone: | 2.42 |
| Component: | GTK+ Client | Version: | 2.41 |
| Severity: | Normal | Keywords: | |
| Cc: |
Description
About dialogs created with gtk_show_about_dialog() are modal since GTK+ 3.0. Transmission does not use gtk_show_about_dialog(), so its about dialog has to be made modal manually to avoid inconsistency with other applications.
Attachments (1)
Change History (7)
Changed 10 years ago by fmuellner
comment:1 Changed 10 years ago by jordan
- Milestone changed from None Set to 2.50
- Status changed from new to assigned
Thank you for the report and the patch!
In the past, we didn't use gtk_show_about_dialog() because we were trying to be compatible with GTK versions older than 2.6. However, Transmission 2.40's minimum is GTK+ 2.22 so the simplest answer is probably to just use gtk_show_about_dialog()...
comment:2 Changed 10 years ago by jordan
- Keywords backport-2.4x added
- Resolution set to fixed
- Status changed from assigned to closed
Fixed in r12968.
comment:3 Changed 10 years ago by Hairy
seems as a side effect of this change that when you hide then re-show the transmission window that the aboutbox pops up as well
comment:4 Changed 10 years ago by livings124
- Resolution fixed deleted
- Status changed from closed to reopened
comment:5 Changed 10 years ago by jordan
- Resolution set to fixed
- Status changed from reopened to closed
This is fixed now in r12980. Thanks for spotting that!
comment:6 Changed 10 years ago by jordan
- Keywords backport-2.4x removed
- Milestone changed from 2.50 to 2.42
Note: See
TracTickets for help on using
tickets.
Make about dialog modal when compiled with GTK+-3