Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4637 closed Enhancement (fixed)

Allow sorting by size in the web ui

Reported by: marcus Owned by: jordan
Priority: Normal Milestone: 2.50
Component: Web Client Version: 2.42
Severity: Normal Keywords:
Cc:

Description

The GTK ui allows sorting by torrent size, however the webui does not.

Attachments (1)

sort_by_size.diff​ (2.2 KB) - added by marcus 9 years ago.

Download all attachments as: .zip

Change History (11)

Changed 9 years ago by marcus

comment:1 Changed 9 years ago by marcus

I tried a patch myself, it works but no idea if it's any good. Pointers very welcome :)

comment:2 Changed 9 years ago by marcus

Not even a reaction? Are patches so unwelcome here?

comment:3 Changed 9 years ago by jordan

It's more a question of the developers being busy. Don't be thin-skinned. :)

comment:4 Changed 9 years ago by x190

PTL, he's still alive! So it wasn't terminal turkey overdose after all. :lol: Happy Thanksgiving guys! :-)

comment:5 Changed 9 years ago by jordan

x190: lol :)

Don't worry about me. I started a new job recently and have been spending my time trying to get up to speed there... that's why I've been gone lately :)

comment:6 Changed 9 years ago by livings124

This is sorting based on size when done, but the actual interface displays the torrent's complete size regardless of selected files. This should sort based on that value (total size regardless of which files are selected).

comment:7 Changed 9 years ago by jordan

  • Milestone changed from None Set to 2.50
  • Owner set to jordan
  • Status changed from new to assigned

r13101: added marcus' patch, tweaked based on livings125's comment:6 to use torrent.getTotalSize() instead of torrent.getSizeWhenDone()

livings124, is this what you had in mind?

comment:8 Changed 9 years ago by livings124

Looks good to me.

comment:9 Changed 9 years ago by livings124

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:10 Changed 9 years ago by killemov

I would have made everything relative to sizeWhenDone as that makes the system way more consistent with eta and percentDone. (I have done so in Shift.)

Note: See TracTickets for help on using tickets.