Opened 9 years ago

Closed 8 years ago

#4665 closed Bug (incomplete)

Transmission won't build using Solaris Studio compilers

Reported by: cgaspar Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.42
Severity: Normal Keywords: patch_needed
Cc:

Description

The issues are all in third-party/libutp:

templates.h, utp.cpp: invalid #pragma pack syntax Makefile.am: unconditional addition of -fno-exceptions -fno-rtti -ansi

Attached are diffs against trunk fixing these.

Attachments (3)

libutp_Makefile_am.diff​ (318 bytes) - added by cgaspar 9 years ago.
Remove gcc-isms from Makefile.am
libutp_templates_h.diff​ (609 bytes) - added by cgaspar 9 years ago.
Conditionalize #pragma pack/unpack in templates.h
libutp_utp_cpp.diff​ (547 bytes) - added by cgaspar 9 years ago.
Conditionalize #pragma pack/unpack in utp.cpp

Download all attachments as: .zip

Change History (13)

Changed 9 years ago by cgaspar

Remove gcc-isms from Makefile.am

Changed 9 years ago by cgaspar

Conditionalize #pragma pack/unpack in templates.h

Changed 9 years ago by cgaspar

Conditionalize #pragma pack/unpack in utp.cpp

comment:1 Changed 9 years ago by jordan

Thank you, but these should be reported upstream to ​https://github.com/bittorrent/libutp -- after they're fixed upstream, I'll pick up the changes here.

comment:2 Changed 9 years ago by cgaspar

Makefile.am isn't sourced from upstream, so at least that bug is firmly transmission's.

comment:3 Changed 9 years ago by jordan

Good point.

Those CPPFLAGS arguments were taken directly from ​upstream's Makefile so I'd rather not remove them unconditionally.

Could revise your Makefile.am patch to keep those flags iff gcc is used, and also to do the Right Thing if Solaris Studio is detected?

comment:4 Changed 9 years ago by livings124

  • Milestone changed from None Set to 2.53
  • Resolution set to fixed
  • Status changed from new to closed

I believe this is fixed with r13317.

comment:5 Changed 9 years ago by cgaspar

  • Resolution fixed deleted
  • Status changed from closed to reopened

Makefile.am is still broken.

comment:6 Changed 9 years ago by jordan

  • Milestone changed from 2.53 to None Set

Please see comment:3

comment:7 Changed 9 years ago by jordan

To clarify what I said in the previous comment:

If Solaris Studio requires a special case for the CPPFLAGS, I'd prefer a patch that modifies CPPFLAGS if and only if it detects that we're trying to build for Solaris Studio. Otherwise, we should default to using upstream libutp's CPPFLAGS.

If such a patch were submitted and didn't have other problems, I'd use it.

comment:8 Changed 9 years ago by jordan

  • Keywords patch_needed added

comment:9 Changed 8 years ago by livings124

cgaspar: ping

comment:10 Changed 8 years ago by jordan

  • Resolution set to incomplete
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.