Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4683 closed Bug (fixed)

Info window swapped view heights not constrained to screen size

Reported by: nickshanks Owned by: livings124
Priority: Normal Milestone: 2.50
Component: Mac Client Version: 2.42
Severity: Normal Keywords:
Cc:

Description (last modified by livings124)

The info window ignores the screen height when resizing a view to a height saved in the user defaults.

1) set your screen to it's highest resolution
2) open transmission, open an info window, select one of the resizable tabs (trackers, peers, files)
3) expand the info window so that it fills the height of your screen
4) switch to another info window tab
4.5) quit transmission?
5) change the screen resolution down to a much lower value
5.5) relaunch transmission?
6) select the tab who's size you grew in step 3

Expected result: the window would be constrained to the new screen height and the view height would correspond to this.

Actual result: the window is constrained by the OS but the view inside it is not. It's frame height is set to a huge value, sending the top of the view out of the window's bounds and covering up what would be in the top half of the info panel.

Attachments (1)

constrain_view_height_to_screen.diff (48.3 KB) - added by nickshanks 9 years ago.
patch which fixes issue. changes class of root view in 3 nib files

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by nickshanks

patch which fixes issue. changes class of root view in 3 nib files

comment:1 Changed 9 years ago by livings124

  • Version changed from 2.42+ to 2.42

comment:2 Changed 9 years ago by livings124

  • Description modified (diff)

comment:3 follow-up: Changed 9 years ago by livings124

r13114 has a similar implementation of your patch in InfoWindowController?'s setTab: method. nickshanks, does this change work as you would expect?

comment:4 Changed 9 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed

comment:5 Changed 9 years ago by livings124

  • Milestone changed from None Set to 2.50

comment:6 in reply to: ↑ 3 Changed 9 years ago by nickshanks

Replying to livings124:

r13114 has a similar implementation of your patch in InfoWindowController?'s setTab: method. nickshanks, does this change work as you would expect?

Might do, I'm on a Mac at the moment but not one with Transmission checked out, and only an old version of Xcode. It might have to wait until after New Year before I can check. I tried to do the patch in the view controllers, but found the window was nil. Your patch looks much nicer that screwing around with al the nib files and adding a new class.

comment:7 Changed 9 years ago by livings124

You can download nightly builds from https://build.transmissionbt.com/.

Note: See TracTickets for help on using tickets.