Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#4684 closed Bug (fixed)

tr_cpSizeWhenDone() is slow for huge torrents that we're only partially downloading

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.50
Component: libtransmission Version: 2.40
Severity: Normal Keywords:
Cc:

Description

Summary pretty much says it all.

There are actually two different implementations of the byte-counting in that function: a slower implementation was added prior to 2.40 in r12918 to double-check the standard implementation.

This checking was added to help smoke out a bug that was fixed in r12920, but I forgot to remove that slower implementation.

See also #4496 wrt tr_cpSizeWhenDone() being slow when processing huge torrents.

Change History (3)

comment:1 Changed 9 years ago by jordan

fixed in r13113

comment:2 Changed 9 years ago by jordan

  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed 9 years ago by cfpp2p

a keen eye for tight code gives transmission a very merry Christmas...

Note: See TracTickets for help on using tickets.