Opened 10 years ago

Closed 10 years ago

#4700 closed Bug (fixed)

alloca.h breaks build on FreeBSD (but isn't needed anyway)

Reported by: roeme Owned by: jordan
Priority: Normal Milestone: 2.50
Component: libtransmission Version: 2.42
Severity: Minor Keywords: alloca bsd
Cc:

Description

I have just tried to compile transmission from source on a FreeBSD system. It didn't work out of the box, since libtransmission/peer-msgs.c includes alloca.h.

This header file isn't available on *BSD systems as well as Mac OS X. The function alloca() however, is available in glibc, and was implemented in *BSD's stdlib.h (non-glibc) as well.

FIX:

By simply removing the #include directive, compilation will not choke on this (though on other things - refer to http://1984.roeme.ch/2012/01/compiling-transmission-fun-freebsd/ if interested - , but I'll create separate tickets for that).

Thanks and keep up your awesome work.

Change History (2)

comment:1 Changed 10 years ago by jordan

  • Milestone changed from None Set to 2.50
  • Status changed from new to assigned

fixed in r13154

comment:2 Changed 10 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.