Opened 7 years ago

Last modified 7 years ago

#4703 reopened Enhancement

Remove libtransmission API for configuring units

Reported by: elpres Owned by: jordan
Priority: Lowest Milestone: None Set
Component: Web Client Version: 2.42
Severity: Normal Keywords:
Cc:

Description

For a file with the size of 1,569,406,976 bytes, the desktop client (Mac) shows 1.57 GB, while in the web interface it's 1.46 GB, i.e. the first is in Gigabytes and the second one in Gibibytes. They should both use the same base for consistency.

Attachments (1)

web-interface-iec-units.patch​ (970 bytes) - added by mihaic 7 years ago.
Web interface IEC units patch

Download all attachments as: .zip

Change History (14)

comment:1 Changed 7 years ago by jordan

  • Component changed from Transmission to Web Client
  • Owner set to jordan
  • Status changed from new to assigned

Changed 7 years ago by mihaic

Web interface IEC units patch

comment:2 Changed 7 years ago by mihaic

The units problem was fixed in ticket #3174. The web interface was made to use IEC units in r10536, but later code changes reverted the web interface to the old customary units.

I'm attaching a patch that makes the web interface use the IEC units again.

comment:3 Changed 7 years ago by livings124

The Web UI should reflect the speed/size base set in libTransmission by the client.

comment:4 Changed 7 years ago by mihaic

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r13195.

comment:5 Changed 7 years ago by livings124

  • Resolution fixed deleted
  • Status changed from closed to reopened
  • Summary changed from Displayed file size differs between desktop version and web interface to The Web UI should reflect the speed/size base set in libTransmission by the client

comment:6 Changed 7 years ago by jordan

livings124, is that not currently the case?

Unless I'm not mistaken, the Mac, GTK+, Qt, and Web clients are all on the same page wrt displayed units, and AFAIK it's not configurable in any of the GUIs.

comment:7 Changed 7 years ago by livings124

libT gives an option for setting the units. The web ui hardcodes the units. It should be one way or the other.

Last edited 7 years ago by livings124 (previous) (diff)

comment:8 Changed 7 years ago by jordan

Let's remove the option >:)

comment:9 Changed 7 years ago by livings124

Works for me. Let's just hope Apple doesn't change it to something from base 10.

comment:10 Changed 7 years ago by jordan

  • Milestone changed from None Set to 2.51
  • Priority changed from Low to Lowest
  • Summary changed from The Web UI should reflect the speed/size base set in libTransmission by the client to Remove libtransmission API for configuring units

comment:11 Changed 7 years ago by livings124

This ticket conflicts with #4747.

comment:12 Changed 7 years ago by livings124

  • Milestone changed from 2.51 to None Set

comment:13 Changed 7 years ago by jordan

  • Type changed from Bug to Enhancement
Note: See TracTickets for help on using tickets.