Opened 11 years ago
Closed 11 years ago
#4717 closed Bug (fixed)
Help gettext to differentiate between gerund and verb uses of "Downloading" and "Seeding"
Reported by: | realplus | Owned by: | jordan |
---|---|---|---|
Priority: | Normal | Milestone: | 2.50 |
Component: | GTK+ Client | Version: | 2.42 |
Severity: | Normal | Keywords: | |
Cc: |
Description
There is a string "Downloading" occurs at
../gtk/details.c:563 ../gtk/filter.c:698 ../gtk/tr-prefs.c:1284
three places.
However, "Downloading" in gtk/tr-prefs.c is a noun for Download, while in gtk/filter.c and gtk/detail.c are referring as the "downloading" in "File is downloading now." That is a verb.
Many languages distinguishes verb and noun into different forms, for example, Chinese."Downloading" in gtk/tr-prefs.c is "下載", and the other is "正在下載"。
It is better to separate them into two individual ones. As far as I know, adding some comments in the translation template may make each of them as unique ones.
Change History (8)
comment:1 Changed 11 years ago by livings124
- Component changed from Transmission to GTK+ Client
- Owner set to jordan
comment:2 Changed 11 years ago by jordan
- Keywords patch-needed added
comment:3 Changed 11 years ago by jordan
- Status changed from new to assigned
comment:4 Changed 11 years ago by realplus
"Seeding" need ungrouping too.
I am sorry that I don't know how to use svn and get the pot file. But I can point out how to edit the pot template file.
Before:
#: ../gtk/details.c:563 #: ../gtk/filter.c:698 #: ../gtk/tr-prefs.c:1284 msgid "Downloading" msgstr ""
=> After:
#: ../gtk/details.c:563 #: ../gtk/filter.c:698 msgid "Downloading" msgstr "" #. heading in the preference #: ../gtk/tr-prefs.c:1284 msgid "Downloading" msgstr ""
Before:
#: ../gtk/details.c:565 #: ../gtk/filter.c:699 #: ../gtk/tr-prefs.c:347 msgid "Seeding" msgstr ""
=> After:
#: ../gtk/details.c:565 #: ../gtk/filter.c:699 msgid "Seeding" msgstr "" #. heading in the preference #: ../gtk/tr-prefs.c:347 msgid "Seeding" msgstr ""
comment:5 Changed 11 years ago by jordan
- Keywords patch-needed removed
- Milestone changed from None Set to 2.50
comment:6 Changed 11 years ago by jordan
- Severity changed from Major to Normal
- Summary changed from Translation template needs better support for non-English languages to Help gettext to differentiate between gerund and verb uses of "Downloading" and "Seeding"
I wasn't sure how to do this, so for the benefit of my future self or anyone else who's interested, here are some breadcrumbs I found:
http://live.gnome.org/GnomeGoals/MsgctxtMigration
http://developer.gnome.org/glib/2.31/glib-I18N.html#C-:CAPS
http://developer.gnome.org/glib/2.31/glib-I18N.html#NC-:CAPS
comment:7 Changed 11 years ago by jordan
Fixed in r13192
comment:8 Changed 11 years ago by jordan
- Resolution set to fixed
- Status changed from assigned to closed
I agree with the goals of this ticket. realplus, if you want to submit a patch based off of svn trunk, I will happily use it.
Are these the only strings that need ungrouping?