Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4732 closed Bug (fixed)

Allow switching between internal and system libnatpmp

Reported by: scarabeus Owned by: jordan
Priority: Normal Milestone: 2.50
Component: Transmission Version: 2.42
Severity: Normal Keywords:
Cc:

Description

As per topic this should be switchable same as for the upnpc.

Attachments (1)

transmission-2.42-natpmp-system.patch (9.0 KB) - added by scarabeus 7 years ago.
patch against 2.50 or any version that has the upnpc switch included

Download all attachments as: .zip

Change History (12)

Changed 7 years ago by scarabeus

patch against 2.50 or any version that has the upnpc switch included

comment:1 Changed 7 years ago by jordan

  • Owner set to jordan
  • Status changed from new to assigned

scarabeus, a couple of comments about this patch:

  1. Could you go into more detail about the include path changes to libtransmission's Makefile? Clearly it works but I'm not sure why. :)
  1. The patch has a small error in configure.ac, fixed this way:
- LIBNATPMP_LIBS="\$(top_builddir)/third-party/natpmp/libnatpmp.a"
- LIBNATPMP_LIBS_QT="\$\${TRANSMISSION_TOP}/third-party/natpmp/libnatpmp.a"
+ LIBNATPMP_LIBS="\$(top_builddir)/third-party/libnatpmp/libnatpmp.a"
+ LIBNATPMP_LIBS_QT="\$\${TRANSMISSION_TOP}/third-party/libnatpmp/libnatpmp.a"
  1. The Qt portions of this patch don't match the 'upstream' 2.42 tarball at all. I think your distro must be using its own build code for the Qt client.

comment:2 Changed 7 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Patch applied (with possible upstream breakage from me?) to r13199.

scarabeus, you might want to give this version a try and see how it works for you...

comment:3 Changed 7 years ago by scarabeus

  • Resolution fixed deleted
  • Status changed from closed to reopened

1) the internal libs were really pointint to libnatpmp, good catch. 2) those includes were overly too broad, so they were never needed and i tend rather lower includes if possible to reduce possibility of errors. 3) then the qt difference must really be from other patch, i suspect this one: http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/net-p2p/transmission/files/transmission-2.33-0002-config.in-4-qt.pro.patch?hideattic=0&revision=1.1&view=markup

If you are interested in complete patchset we are now using against 2.42 it is here in handy tarball: http://dev.gentoo.org/~ssuominen/transmission-2.42-patchset-1.tar.xz

Reopening for now as the qt part of the patch was needed (it is my fault that i didn't notice that this patch is not applied, sorry about that).

comment:4 Changed 7 years ago by jordan

Actually what I'd like is for you to try a svn build or nightly tarball and see if things work for you -- a related ticket (#4490) from the Debian people has addressed has (I think) addressed the Qt build issues.

comment:5 Changed 7 years ago by collegeitdept

Is this the bug that is holding up the release of Transmission 2.5 on the Mac?

I LOVE transmission and have been following the development of 2.5 for the past few months. It's been over 4 months since the last official release of Transmission. I was getting kinda worried and can't wait for this major release!

(XProtect malware support is by far the most important feature! It will help all Mac users and the Mac universe - but remain behind the scenes and unnoticeable).

Seriously, Transmission developers... Keep up the EXCELLENT work!!!!

(Sorry if I seem impatient).

comment:6 Changed 7 years ago by livings124

The wait for 2.5 shouldn't be too much longer.

comment:7 Changed 7 years ago by collegeitdept

Thank you!

comment:8 Changed 7 years ago by jordan

scarabeus, any news? :)

comment:9 Changed 7 years ago by scarabeus

Looks like 2.5 is fine for us, sorry for the lag.

comment:10 Changed 7 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

Great, glad to hear it. Thanks for the confirmation

comment:11 Changed 7 years ago by jordan

Is your filesystem encrypted? What filesystem are you saving to?

Note: See TracTickets for help on using tickets.