Opened 9 years ago

Closed 9 years ago

#4739 closed Enhancement (fixed)

Webkit notifications for downloading/seeding complete events

Reported by: htxir Owned by:
Priority: Normal Milestone: 2.60
Component: Web Client Version: 2.42
Severity: Normal Keywords:
Cc:

Description

Chrome has supported desktop notifications for some time. This patch adds toggle-able for notifications for download & seeding complete events.

Added as part of this patch is a sort of key-value-observing on torrents, where interested parties can be notified when certain fields of a torrent change (in this case, status).

Attachments (1)

notifications.patch (4.3 KB) - added by htxir 9 years ago.
svn diff

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by htxir

svn diff

comment:1 Changed 9 years ago by livings124

  • Milestone changed from 2.50 to None Set

Thanks for the patch! Changing milestone since 2.50 is frozen.

comment:2 Changed 9 years ago by livings124

  • Milestone changed from None Set to 2.60
  • Resolution set to fixed
  • Status changed from new to closed

Committed in r13308. Thanks!

comment:3 Changed 9 years ago by sergio

  • Resolution fixed deleted
  • Status changed from closed to reopened

Just so you won't miss it, this patch adds a new file to the javascript dir but leaves the Makefile untouched. As a result, the new notifications.js will not be installed properly.

comment:4 Changed 9 years ago by sergio

Also I believe the image path at https://trac.transmissionbt.com/browser/trunk/web/javascript/notifications.js?rev=13308#L18 should read

transmission/web/style/transmission/images/logo.png

no?

comment:5 Changed 9 years ago by livings124

Are you sure that last change is correct? That gives me a broken image in Chrome 19.0.1084.56 on 10.7.4.

comment:6 Changed 9 years ago by livings124

r13348 adds notifications.js to the makefile.

comment:7 Changed 9 years ago by livings124

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.