Opened 7 years ago

Closed 7 years ago

#4744 closed Bug (fixed)

[PATCH] Fix IT_PROG_INTLTOOL failing if intltool is not installed

Reported by: Adys Owned by:
Priority: Normal Milestone: None Set
Component: Transmission Version: 2.42
Severity: Normal Keywords:
Cc:

Description

The attached patch fixes IT_PROG_INTLTOOL being compiled by autoconf into a syntax error.

If IT_PROG_INTLTOOL is not defined, autoconf will just compile it into IT_PROG_INTLTOOL(0.35.0,no-xml), which is completely invalid shell and will error out if intltool is not installed.

Since transmission supports builds with --disable-nls, it's reasonable to check if IT_PROG_INTLTOOL is defined before compiling it.

Attachments (2)

transmission-intltool.patch​ (467 bytes) - added by Adys 7 years ago.
patch to configure.ac
transmission-intltool3.patch​ (880 bytes) - added by Adys 7 years ago.
try 3

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by Adys

patch to configure.ac

comment:1 Changed 7 years ago by jordan

  • Milestone changed from None Set to 2.50
  • Resolution set to fixed
  • Status changed from new to closed

Applied in r13189 for 2.50. Thanks Adys!

comment:2 Changed 7 years ago by jordan

  • Milestone changed from 2.50 to None Set
  • Resolution fixed deleted
  • Status changed from closed to reopened

Adys pointed out in IRC that the above patch is the first version -- the second version, ​http://dedimine.com/public/transmission-intltool.patch, was not included in trac.

Also from IRC:

<Adys> jordan: btw, if --enable-nls is given and intltool is missing, configure will keep going and build will fail at make. its better than before but it should fail gracefully at configure time instead

IMO this is just trading one problem for another. Would it be possible for you to revise the patch s.t. it does fail gracefully iff intltool is missing when --enable-nls is passed in?

Changed 7 years ago by Adys

try 3

comment:3 Changed 7 years ago by Adys

That third patch fails gracefully if intltool is missing and advises the user to --disable-nls or install intltool and run autogen.sh again.

comment:4 Changed 7 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed in trunk by r13193 for 2.50. Thanks Adys!

Note: See TracTickets for help on using tickets.