Opened 7 years ago

Closed 7 years ago

#4798 closed Enhancement (duplicate)

Added ability to Change location of torrents via the web interface.

Reported by: joehillen Owned by: joehillen
Priority: Normal Milestone: None Set
Component: Web Client Version: 2.50
Severity: Normal Keywords:
Cc:

Description

Hi all,

I've made changes so that it's possible to set the download location via the web interface.

I'm not sure how to submit these changes for review, so I put them on github:

https://github.com/joehillen/transmission/commit/c1c16c5a1e70efc26a39985ec896c28107d69702

Let me know what you think.

Also, I must say that the web interface's codebase was superbly well written, and it was a pleasure to work with.

Thanks for the awesome project (and please switch to git).

Change History (9)

comment:1 Changed 7 years ago by cfpp2p

initial testing --> functions well ! :)

awesome project, yes ...sorry, not a big fan of git :-( ...

comment:2 Changed 7 years ago by jordan

I haven't tested this patch yet, but it looks short & sweet....

comment:3 Changed 7 years ago by cfpp2p

With testing I have found a bug.

If anyone wants the patch to fix the following bug just PM me on the forums for a simple and clean single line patch to always show the correct path.

If inspector has NOT been opened with the particular torrent selected AND this single torrent is then selected for set location the "Location:" shown in the "Set Location" message box can be either --> blank OR INCORRECT ( using a previously selected location [if previously set location done and/or previously selected torrent with inspector open ] or the most recent previous torrents set location path).

The path shown in the set location message box should show either the current actual location path OR whatever is being typed in but it is incorrect to not show the true path when the set location message box is first opened.

It is confusing to see a default path shown which is sometimes the true actual path and other times a previously used path.

comment:4 Changed 7 years ago by joehillen

Thanks for the info.

I'll probably have some more time to work on it this weekend.

comment:5 Changed 7 years ago by joehillen

So I fixed that populating path issue, and a little bit of styling.

https://github.com/joehillen/transmission/compare/86f083d34faab5cf77b4bf8fe62a74570c9df58e...bf2c95996b36763784bda656bdb95edd8c38c913

If I understand you correctly, the desired behaviour is still to pre-populate the location picker with the default path if multiple torrents are selected at once, right?

comment:6 Changed 7 years ago by cfpp2p

joehillen,

Your updated code fixed the path issue identically to how I patched. The styling is nice; now longer paths show better and are easier to edit.

All looking great to me.

comment:7 Changed 7 years ago by cfpp2p

I have been using joehillen's patch for a while now and I see no reason why it is not being implemented.

Last edited 7 years ago by cfpp2p (previous) (diff)

comment:8 Changed 7 years ago by joehillen

If there is anything I need to do to help this get out, let me know.

Thanks.

comment:9 Changed 7 years ago by livings124

  • Resolution set to duplicate
  • Status changed from new to closed

Closing this thread for the newer duplicate #4993

Note: See TracTickets for help on using tickets.