Opened 9 years ago

Closed 9 years ago

#4820 closed Bug (fixed)

Poor UI/UX for Magnets addition

Reported by: rameshkumar Owned by: jordan
Priority: Normal Milestone: 2.61
Component: Qt Client Version: 2.50
Severity: Normal Keywords:
Cc:

Description

Most of the large public BT sites have gone Magnet only (as you may be aware of).

To add a torrent via Magnet link (if Filetype Magnet is not associated to Transmission and keyboard shortcuts are not used) are:

  1. Copy the Magnet URL to Clipboard.
  2. In the Transmission Client window, Click on "File" menu and then
  3. Click on "Open URL" and Paste the URL there.

Now this is poor UX/UI if I want to add torrents frequently in large no (note: not adding all of them simulatneously).

It can be improved by:-

A. 1. Provide button in the toolbar to add magnet links directly.

OR

  1. Change the default behavior of existing button to add from Magnet links instead of adding torrent files.

B. Please add support for Drag and Drop of Magnet links also

(as the way torrent files D2D is supported)

(See: http://sourceforge.net/projects/trqtw/forums/forum/1315797/topic/5086892)

Thanks.

Attachments (3)

Transmission+urlButton.png (22.1 KB) - added by rb07 9 years ago.
Screen shot of Transmission-Qt modified with patch.
mainwin.cc.patch (1 bytes) - added by rb07 9 years ago.
Deleted.
url-button.patch (2.2 KB) - added by rb07 9 years ago.
Improved patch.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 9 years ago by livings124

What client is this for? The Mac client already allows most/all of this.

Changed 9 years ago by rb07

Screen shot of Transmission-Qt modified with patch.

comment:2 Changed 9 years ago by rb07

  • Component changed from Transmission to Qt Client
  • Owner set to jordan

He's talking about the Qt client.

The modifications are very easy, I added the required patch which results in the application looking like this:

https://trac.transmissionbt.com/attachment/ticket/4820/Transmission%2BurlButton.png

comment:3 Changed 9 years ago by jordan

rb07, the idea and screenshot looks great but this is what I'm getting when I try to apply the patch:

$ patch -p0 < ~/Downloads/url-button.patch 
patching file qt/mainwin.cc
patch: **** malformed patch at line 15: @@ -1304,7 +1309,8 @@

comment:4 Changed 9 years ago by rb07

Sorry about that, I tried to clean the patch taking out all the Windows changes I've made, looks like it didn't work.

I'll make a new patch for mainwin.cc; the mainwin.ui part was not changed.

comment:5 Changed 9 years ago by rb07

New, correct patch added.

Ignore the second part of the comment, I meant mainwin.cc.patch is not needed, both changes are in the url-button.patch; I just didn't find a way to delete the other file.

comment:6 Changed 9 years ago by jordan

  • Milestone changed from None Set to 2.51
  • Status changed from new to assigned

comment:7 Changed 9 years ago by jordan

  • Milestone changed from 2.51 to 2.60

comment:8 Changed 9 years ago by rameshkumar

@jordan You have set the milestone for this bug to 2.60. Is there anything holding back this from landing in 2.51 as requisite patch has been already submitted by @rb07?

I request you to please let this land in 2.51 milestone for the users benefits.

Anyway thanks.

Changed 9 years ago by rb07

Deleted.

comment:9 Changed 9 years ago by rb07

"Improved" in the sense that with the previous patch URLs and magnets behaved different, one opened the one-line "Open URL or magnet link" panel, the other opened the full "Open torrent" panel.

To make things consistent now both open the small panel.

This was discovered by a user that D&D a magnet link, then pushed "Verify local data" which made the application crash. Verify makes no sense, and it can be disabled for these 2 cases (I didn't include the change to disable that button for URLs and magnets, which I also have added to the application), but a couple of the other options on the full panel could be "nice to have" (set location, start paused).

Changed 9 years ago by rb07

Improved patch.

comment:10 Changed 9 years ago by rb07

Latest patch fixes the following use case:

Preferences has "Show options dialog" set, D&D a magnet or a torrent link from the Web browser.

Before the patch the modal window was behind the browser (in front of the application, which is partially obscured by the Web browser). Since the panel is modal, it blocks any use of the Web browser until you find the small panel and click OK, Cancel, or close it.

The patch just adds a hint to the Window manager to show and keep the panel on top. It works on Windows, may or may not work with other Window managers.

Disclaimer: You may have noticed that the Preferences option was about options, and there are no options on the small panel... maybe its a better idea to get rid of this panel, and open the full panel with options, just the ones that don't apply to links disabled.

Last edited 9 years ago by rb07 (previous) (diff)

comment:11 Changed 9 years ago by jordan

  • Milestone changed from 2.60 to 2.70

comment:12 Changed 9 years ago by jordan

  • Milestone changed from 2.70 to 2.61
  • Resolution set to fixed
  • Status changed from assigned to closed

Added in r13385. Thanks :)

Note: See TracTickets for help on using tickets.