Opened 6 years ago

Closed 6 years ago

#4824 closed Bug (fixed)

Open Folder bug , Delete Files bug

Reported by: rameshkumar Owned by: jordan
Priority: Normal Milestone: 2.51
Component: Qt Client Version: 2.50
Severity: Normal Keywords:
Cc:

Description

3 issues- in Transmission Qt Client

1. Select a torrent job from list of downloads,

Right click & Select option "Open Folder" (or press Ctrl + E keys)

Transmission opens the folder in which file (or folder in case of multiple files) of selected torrent job have been downloaded but does not sets the focus on it (the relevant file or folder).

This causes users to search the files in the parent folder unnecessarily if there are lots of files and folders present. [See http://img543.imageshack.us/img543/2118/1969ab7e3d214f6c92799bd.png]

2. Delete a torrent job using "Delete files and remove" option or press Shift + Del keys),

the files deleted (including .torrent file and the data) are not send to Trash (or Recycle Bin) but instead permanently deleted.

This behavior is inconsistent with other apps which by default delete to trash(or recycle bin).

3. Also There is no option to open folder of particular torrent job from toolbar.

Attachments (1)

OpenFolder.patch (1.7 KB) - added by rb07 6 years ago.
openFolder() modified to go one level down, if possible, else select the file (platform/desktop dependent for Windows and Mac)

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by livings124

  • Component changed from Transmission to Qt Client
  • Owner set to jordan

comment:2 Changed 6 years ago by rb07

Issues 1 and 2 are Windows specific, they should work on Linux, I don't know about Mac, but the Windows port (and this is not the place to report anything about any 3rd party port) doesn't.

comment:3 Changed 6 years ago by rameshkumar

I tested Transmission on Ubuntu 11.04.

I can say Issues 1 and 2 are definitely occurring on Linux (Ubuntu).

I. In case of 1, when you open folder for the torrent job,

(a)For multiple files, Transmission opens the folder containing relevant files instead of opening parent folder (which is OK)

(b)For a single file (say a PDF file), Transmission opens the parent folder but does not sets focus on (or highlights) the relevant file in Nautilus (which is NOT OK).

II. In case of issue 2, When you delete a torrent job (as described my me above),

Transmission deletes the data files to Trash but Not the torrent file. It deleted the torrent file permanently (This is NOT OK, Inconsistent I may say).

III. Issue 3 is part of Transmission Qt client on all platforms.

Thanks.

comment:4 Changed 6 years ago by rb07

I'm not a Transmission developer, and this is not a forum to start discussing things, but...

On issue 2, you are wrong: the torrent file was deleted or not according to your Preferences when the torrent was initially loaded.

The torrent file transmission keeps as a copy is not for the user, so its not treated as such which is consistent.

It doesn't help if you report different issues as if they where the same problem. What happens in Windows (irrelevant to this tracker) is not the same as what happens in Linux.

Issue 1 too specific: how to set focus on <fill-your-favourite-file-browser-and-operating-system-here>. I haven't seen the details, but it looks too difficult to implement (i.e. each file browser probably has its own API; but Linux may have a (freedesktop.org) standard). Actually Qt does have a standard way to do it, but doesn't have the option to select the file or directory, the only option is to open the torrent's location directory, nothing else. But see (1) for an OS dependent workaround.

Issue 3 is probably a (good) design decision: 2 "open" buttons on the same tool bar? that would create a lot of confusion, "open torrent" / "open folder" ... looks (icon) and sounds about the same. But when you have in the menu File->Open... and Torrent->Open Folder, that makes things clear.

Sorry for the off-topic tirade, this really belongs to the forum, not here.

(1) http://stackoverflow.com/questions/9137692/qdesktopservicesopenurl-with-selecting-specified-file-in-explorer

Last edited 6 years ago by rb07 (previous) (diff)

comment:5 follow-up: Changed 6 years ago by rameshkumar

@rb07 Any progress? Anyway "Open Folder" is a good option for many anyway for removing confusion as you said one can provide a tooltip or one can also change the design or color of the icon.

Anyway thanks for your efforts. I appreciate it.

comment:6 in reply to: ↑ 5 Changed 6 years ago by rb07

Replying to rameshkumar:

@rb07 Any progress? Anyway "Open Folder" is a good option for many anyway for removing confusion as you said one can provide a tooltip or one can also change the design or color of the icon.

Anyway thanks for your efforts. I appreciate it.

I have changed the Windows version to open the torrent's folder, if it has one, or open the download folder with the file selected. The change will be available with the next release (of the unofficial Windows port -- trqtw).

This is a Windows only change, I have some untested code for Mac OSX, and for Linux it opens the torrent's top folder, if any, and nothing is selected. I'll add the change as a patch here.

I've also added the use of 'Recycle Bin' to the Windows port. Its not as good as the Linux code (which I don't know if it works) since I had to just delete the entire contents to preserve the structure, that means that if you added something (for instance, opened a compressed archive in place), then it gets sent to the Trash also (the Linux code goes through great lengths not to do that).

Another 'detail' is that now the .torrent file always gets sent to the 'Recycle Bin' (on Windows)... in the specific code I can't know if that is wanted or not (the Preferences setting, which I added, is not readily available).

I have no code for Mac OSX, and only a vague idea for Linux (which according to another ticket already uses the Trash can -- but I don't see how that is possible with the daemon, or desirable, i.e. no desktop means no Trash, perhaps I misunderstood and its only for the GTK+ app), so I will not send a patch for this change.

Last edited 6 years ago by rb07 (previous) (diff)

Changed 6 years ago by rb07

openFolder() modified to go one level down, if possible, else select the file (platform/desktop dependent for Windows and Mac)

comment:7 Changed 6 years ago by jordan

  • Milestone changed from None Set to 2.51
  • Resolution set to fixed
  • Status changed from new to closed

Patch added in r13264.

Closing this ticket. Separate issues should go in separate tickets so that they can be tracked on their own, so please resubmit the other issues in their own tickets. Thanks!

Note: See TracTickets for help on using tickets.