Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#4841 closed Bug (fixed)

Ratio can display incorrectly in inspector

Reported by: SanKen Owned by: livings124
Priority: Normal Milestone: 2.51
Component: Web Client Version: 2.50
Severity: Normal Keywords:
Cc:

Description

Do not show the correct ratio of Info

screenshot

http://dl.dropbox.com/u/13296961/ratio.png

please fix this (patch)

Attachments (1)

ratio.png (8.2 KB) - added by SanKen 7 years ago.

Download all attachments as: .zip

Change History (6)

Changed 7 years ago by SanKen

comment:1 Changed 7 years ago by livings124

The difference appears to stem from the fact that the ratio per-row is passed in from libtransmission, while the ratio in the inspector is calculated using the summed upload and download counts (which in this case is just the values for the single torrent).

comment:2 Changed 7 years ago by livings124

  • Summary changed from BUG: Do not show the correct ratio of Info to Ratio can display incorrectly in inspector

The solution is to use the "have-valid" amount when downloaded amount is 0, matching the libtransmission behavior.

comment:3 Changed 7 years ago by livings124

  • Milestone changed from None Set to 2.51
  • Owner set to livings124
  • Priority changed from High to Normal

comment:4 Changed 7 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed

This should be fixed with r13257. Please reopen if it's not.

comment:5 Changed 7 years ago by cfpp2p

thanks for the quick fix. updated yesterday and all looks good now. thanks!

Note: See TracTickets for help on using tickets.