#4915 closed Bug (fixed)
transmission-2.51 missing 2 #include's for FreeBSD compability
Reported by: | samuli | Owned by: | |
---|---|---|---|
Priority: | High | Milestone: | 2.60 |
Component: | Transmission | Version: | 2.51 |
Severity: | Normal | Keywords: | |
Cc: |
Description
transmission-2.51 is failing to compile on a FreeBSD system because of 2 missing #include lines
build log of the failure:
http://bugs.gentoo.org/attachment.cgi?id=312311
the patch that fixes the above build failure:
http://bugs.gentoo.org/attachment.cgi?id=311957
--- third-party/libutp/utp.h +++ third-party/libutp/utp.h @@ -12,7 +12,9 @@
#pragma comment(lib,"ws2_32.lib") #else #include <stdlib.h>
+#include <sys/types.h>
#include <sys/socket.h>
+#include <netinet/in.h>
the downstream bug report:
http://bugs.gentoo.org/400929
alternative patch from official FreeBSD for the same issue:
-- third-party/libutp/utp.cpp.orig 2011-04-29 21:45:38.000000000 -0500 +++ third-party/libutp/utp.cpp 2011-04-29 21:47:05.000000000 -0500 @@ -10,6 +10,9 @@
#include <stdlib.h> #include <errno.h> #include <limits.h> for UINT_MAX
+#include <sys/types.h> +#include <sys/socket.h> +#include <netinet/in.h>
I'll attach these files here too...
Attachments (3)
Change History (11)
Changed 11 years ago by samuli
comment:1 Changed 11 years ago by jordan
Thanks for reporting this issue, but it looks to me like this ought to be handled upstream. Could you file a ticket at https://github.com/bittorrent/libutp?
comment:2 Changed 11 years ago by samuli
Reported it here:
comment:3 Changed 11 years ago by jordan
- Milestone changed from 2.53 to None Set
comment:4 Changed 11 years ago by samuli
The patch was merged to utp git.
comment:5 follow-up: ↓ 7 Changed 11 years ago by livings124
- Resolution set to fixed
- Status changed from new to closed
Fixed in r13317. Thanks!
comment:6 Changed 11 years ago by livings124
- Milestone changed from None Set to 2.53
comment:7 in reply to: ↑ 5 Changed 11 years ago by rb07
Replying to livings124:
Fixed in r13317. Thanks!
Your changes in Mac OSX are leaving the file with Mac OSX line termination (^M^J or \r\n), this causes svn to see most of the file as different (on Linux).
comment:8 Changed 11 years ago by livings124
- Milestone changed from 2.53 to 2.60
build log