Opened 14 years ago

Closed 13 years ago

#496 closed Enhancement (wontfix)

color unavailable pieces in the pieces bar red (IRC)

Reported by: Waldorf Owned by: somebody
Priority: Low Milestone: None Set
Component: Mac Client Version: 0.95
Severity: Normal Keywords:
Cc: ody


Like the availability bar.

Attachments (1)

fix496.diff (2.5 KB) - added by ody 14 years ago.
Revised patch: fixes memory leaks, changes behavior

Download all attachments as: .zip

Change History (7)

comment:1 Changed 14 years ago by livings124

  • Component changed from Transmission to OS X Interface

comment:2 Changed 14 years ago by livings124

I appreciate the patch, but there are two problems with it:

  1. Getting both availability and amount are way too memory intensive.
  2. If you have part of a piece but it's not available, it will show red and not indicate any progress.

comment:3 Changed 14 years ago by ody

For the first problem, is it really? The pieceAvailability array takes up at most MAX_PIECES (324) bytes. And as far as I can tell nothing particularly memory-intensive happens in libtransmission.

For the second problem, how do you want to indicate a piece that you have part of but the rest isn't available? Do you want the behavior to be the same as before except that if you have 0% of a piece and it's unavailable, it's shown in red?

comment:4 Changed 14 years ago by ody

  • Cc ody added

Changed 14 years ago by ody

Revised patch: fixes memory leaks, changes behavior

comment:5 Changed 14 years ago by livings124

Getting availability/piece percent is really expensive, especially with a lot of torrents - profile it if you don't believe me. Also, displaying red only when none has been downloaded is a bit inconsistent imho. I would rather wait for a better solution to convey this information.

That revised path doesn't fix a memory leak, since setPreviousAmountFinished: retains/releases appropriately. Are you sure that patch doesn't cause a segfault?

comment:6 Changed 13 years ago by livings124

  • Resolution set to wontfix
  • Status changed from new to closed

For the 2 problems listed (speed/memory consumption and showing percent AND availability in the same bar), I'm closing this ticket. If someone can come up with a solution for those issues, please reopen this.

Note: See TracTickets for help on using tickets.