Opened 9 years ago

Closed 9 years ago

#4993 closed Enhancement (fixed)

Add Set Location on WebUI

Reported by: luizpaulo Owned by:
Priority: Normal Milestone: None Set
Component: Web Client Version: 2.61
Severity: Normal Keywords:
Cc:

Description

I wrote a patch to add the Set Location functionality on the WebUI. It adds an option on the context menu to set the location of the selected torrents. I used the latest svn (from 25/07/2012). I would be nice if someone could review it. My web skills are a bit rusty and I'm not sure the code is as efficient as it could be. I wrote this patch because it was a feature I was really missing and it didn't seem like it would be that hard to add it.

Attachments (2)

location.patch (8.2 KB) - added by luizpaulo 9 years ago.
Set Location WebUI Patch
0001-Added-change-download-location-functionality-to-web-.patch (7.6 KB) - added by joehillen 9 years ago.
change download location

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by luizpaulo

Set Location WebUI Patch

comment:1 Changed 9 years ago by jordan

  • Component changed from Transmission to Web Client
  • Version changed from 2.61+ to 2.61

Changed 9 years ago by joehillen

change download location

comment:2 Changed 9 years ago by joehillen

I was just about to resubmit my version of this, and then I say this bug.

My first submission was ignored for some reason. https://trac.transmissionbt.com/ticket/4798

It would be nice to know why.

I'm attaching my patch because it involves less code. Let me know what you think. Thanks.

comment:3 Changed 9 years ago by livings124

It wasn't ignored, it just wasn't gotten to. We do appreciate the patch.

comment:4 Changed 9 years ago by luizpaulo

I hope one of these patches (mine or joehillen's) gets approved. It's a simple feature but I really miss it.

comment:5 Changed 9 years ago by jordan

My first submission was ignored for some reason. https://trac.transmissionbt.com/ticket/4798

It would be nice to know why.

We don't really have a person committed to the web ui at the moment. I'm probably the closest person to that description, and it's been very difficult for me to find as much time for Transmission as I'd like.

comment:6 Changed 9 years ago by jordan

  • Resolution set to fixed
  • Status changed from new to closed

The patch looks fine and works as advertised, added in r13439. Thanks!

Note: See TracTickets for help on using tickets.