Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5036 closed Bug (fixed)

Bonjour Service Name Maximum Length Bug

Reported by: wlisac Owned by: livings124
Priority: High Milestone: 2.70
Component: Mac Client Version: 2.61
Severity: Normal Keywords:
Cc: will@…

Description

Bonjour service names are allowed to have a maximum length of 63 characters. When it goes over 63 characters the service fails to advertise.

For example, a service name of "Transmission Web Interface (johnnyappleseed - Johnny Appleseed's MacBook? Pro" will fail to advertise.

I suggest we first attempt to shorten the name by removing "Web Interface" if the name is more than 63 characters. I believe that the user's metadata is more important and it also improves the odds of uniqueness (another requirement for successful bonjour advertisement.)

In the example above, removing "Web Interface" makes it exactly 63 characters and it will succeed. If it is still greater than 63 characters we could simply truncate.

I have included a BonjourController?.m file with these suggested changes.

My main concern with this solution is the lack of naming consistency. Would it make more sense to just rename to "Transmission" regardless of length just to improve consistency?

I'm personally in favor of just renaming to "Transmission (username - computer name)" for everyone. Then we could just truncate >63 characters.

Attachments (1)

BonjourController.m (3.2 KB) - added by wlisac 9 years ago.

Download all attachments as: .zip

Change History (8)

Changed 9 years ago by wlisac

comment:1 Changed 9 years ago by livings124

Good catch! Did you find this 63-character constant documented anywhere?

comment:2 Changed 9 years ago by wlisac

Nothing official. This mailing list is the best source I could find.

http://lists.apple.com/archives/bonjour-dev/2007/Mar/msg00020.html

Thoughts regarding the rename?

comment:3 Changed 9 years ago by livings124

The rename's a good idea.

comment:4 Changed 9 years ago by livings124

Thanks! r13483

comment:5 Changed 9 years ago by livings124

  • Resolution set to fixed
  • Status changed from new to closed

comment:6 Changed 9 years ago by livings124

r13485 always uses "Transmission" instead of "Transmission Web Interface" for consistency

comment:7 Changed 9 years ago by wlisac

r13485- awesome.

Note: See TracTickets for help on using tickets.