Opened 9 years ago

Closed 9 years ago

#5055 closed Enhancement (fixed)

No HTML in Comments

Reported by: JJTagy Owned by: jordan
Priority: Low Milestone: 2.72
Component: Web Client Version: 2.60
Severity: Minor Keywords:
Cc:

Description

Torrents that include HTML in the comment section do not display properly in the Web Inspector.

Attachments (2)

inspector.js.patch (615 bytes) - added by JJTagy 9 years ago.
Revert to InnerHTML for comment section of inspector
updated_inspector.js.patch (487 bytes) - added by JJTagy 9 years ago.

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by JJTagy

Revert to InnerHTML for comment section of inspector

comment:1 Changed 9 years ago by livings124

  • Version changed from 2.60+ to 2.60

comment:2 follow-up: Changed 9 years ago by rb07

This clashes (obviously) with r13392 and the change documented in ticket #4979, which is a CVE fix.

comment:3 in reply to: ↑ 2 Changed 9 years ago by JJTagy

Replying to rb07:

This clashes (obviously) with r13392 and the change documented in ticket #4979, which is a CVE fix.

Understood - then something else needed to be done when a comment includes a url. There is no point having an a-tag replace. New patch added to re-add the change in ticket #4979.

comment:4 Changed 9 years ago by livings124

JJTagy: Can you upload your new patch with a new name? Trac doesn't allow the file with the same name for some reason.

Changed 9 years ago by JJTagy

comment:5 Changed 9 years ago by JJTagy

Absolutely!

comment:6 Changed 9 years ago by jordan

Yeah, looks that replace command goes back to #4521, which is moot after #4979. The use of replace() there should have been torn out as part of the fix for #4979.

JJTagy, thanks for pointing this out. :)

comment:7 Changed 9 years ago by jordan

  • Milestone changed from None Set to 2.72
  • Owner set to jordan
  • Status changed from new to assigned

comment:8 Changed 9 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Committed in r13543.

Note: See TracTickets for help on using tickets.