Opened 8 years ago

Closed 8 years ago

#5072 closed Bug (fixed)

In the torrent list, show how many web seeds we're downloading from

Reported by: cfpp2p Owned by: jordan
Priority: Normal Milestone: 2.72
Component: Transmission Version: 2.71
Severity: Normal Keywords:
Cc:

Description (last modified by jordan)

The Mac client does this well:

If web seeds:

"Downloading from X of Y peer(s) and Z web seed(s)"

Otherwise:

"Downloading from X of Y peer(s)"

The GTK+, Qt, and Web Clients should follow this convention.

Attachments (1)

websd_dwnld.patch (1.2 KB) - added by cfpp2p 8 years ago.

Download all attachments as: .zip

Change History (20)

comment:1 Changed 8 years ago by x190

This applies to the Mac Client as well. See https://trac.transmissionbt.com/ticket/5069#comment:5.

See comment:4 in this ticket.

Last edited 8 years ago by x190 (previous) (diff)

comment:2 follow-up: Changed 8 years ago by livings124

This is working for me in the Mac client. When downloading from a webseed, it says "downloading from 0 of 0 peers + web seed"

comment:3 Changed 8 years ago by livings124

  • Summary changed from web client does not show webseeds or as peers to web client does not show web seed download count

The second part, of displaying the web seed url, is covered in #4876.

comment:4 in reply to: ↑ 2 Changed 8 years ago by x190

Replying to livings124:

This is working for me in the Mac client. When downloading from a webseed, it says "downloading from 0 of 0 peers + web seed"

Does that statement refer to Web Client + Mac Client or just Mac Client or both?

Regardless, the comment:1 link referred to the Inspector->Peers window (webseed url) listing of the Mac Client which may be a separate issue? #4876 refers to the Web Client only.

comment:5 Changed 8 years ago by livings124

Just Mac client.

The URL is also displaying correctly for me in the Mac client.

comment:6 Changed 8 years ago by jordan

  • Milestone changed from None Set to 2.72
  • Owner set to jordan
  • Status changed from new to assigned

This is fixed now in the web client in r13548.

If this is broken in the Mac Client, please open a separate ticket for it. Thanks!

comment:7 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:8 follow-up: Changed 8 years ago by jordan

x190: also, I think #4876 is talking about exposing the webseeds' actual URLs somewhere, which is different from this ticket asking the webseeds to be included in the "downloading from" peer count... at least, if I'm reading the ticket right.

comment:9 in reply to: ↑ 8 Changed 8 years ago by x190

Replying to jordan:

x190: also, I think #4876 is talking about exposing the webseeds' actual URLs somewhere, which is different from this ticket asking the webseeds to be included in the "downloading from" peer count... at least, if I'm reading the ticket right.

See trac ticket #5081.

Last edited 8 years ago by x190 (previous) (diff)

comment:10 Changed 8 years ago by livings124

Instead of include the webseed count as a peer, it should do what the Mac client does:

"Downloading from 0 of 0 peers + web seed"

comment:11 Changed 8 years ago by livings124

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:12 Changed 8 years ago by cfpp2p

how does this look?

http://www.computerfixpro.com/web-seed.JPG

Changed 8 years ago by cfpp2p

comment:13 Changed 8 years ago by jordan

Yes, and promoting the webseedsSendingToUs field into the fields-that-need-to-be-refreshed list is a good move too.

comment:14 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

Patch applied in r13551

comment:15 Changed 8 years ago by livings124

So few torrents have web seeds that I would suggest only appending the extra text when there are. Also, it should be "1 web seed", not "1 web seeds".

comment:16 Changed 8 years ago by livings124

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:17 Changed 8 years ago by jordan

Pluralization / visibility tweak added in r13552.

livings124, please close this ticket if you're happy now ;)

comment:18 Changed 8 years ago by jordan

  • Component changed from Web Client to Transmission
  • Description modified (diff)
  • Summary changed from web client does not show web seed download count to In the torrent list, show how many web seeds we're downloading from

...actually let's fix the pluralization of "peers" too.

And while we're going all out, let's synchronize the GTK+ and Qt clients to this text.

comment:19 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

r13553 makes the changes I described in comment:18

Note: See TracTickets for help on using tickets.