Opened 9 years ago

Closed 9 years ago

#5075 closed Bug (fixed)

magnet.c line 163 should have MAX_WEBSEEDS not MAX_TRACKERS

Reported by: cfpp2p Owned by: jordan
Priority: Normal Milestone: 2.72
Component: libtransmission Version: 2.71
Severity: Normal Keywords:
Cc:

Description

line 163 should be

if( ( vallen > 0 ) && ( keylen==2 ) && !memcmp( key, "ws", 2 ) && ( wsCount < MAX_WEBSEEDS ) )

NOT

if( ( keylen==2 ) && !memcmp( key, "ws", 2 ) && ( wsCount < MAX_TRACKERS ) )

note: this also fixes a crash when a magnet link has a malformed webseed ending with &ws.

magnet:?xt=urn:btih:14FFE5DD23188FD5CB53A1D47F1289DB70ABF31E&dn=ubuntu+12+04+1+desktop+32+bit&tr=http%3A%2F%2Ftracker.publicbt.com%2Fannounce&tr=udp%3A%2F%2Ftracker.publicbt.com%3A80&ws

Change History (3)

comment:1 Changed 9 years ago by jordan

  • Component changed from Transmission to libtransmission
  • Owner set to jordan
  • Status changed from new to assigned

Thanks!

comment:2 Changed 9 years ago by jordan

  • Milestone changed from None Set to 2.72

comment:3 Changed 9 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed r13546.

Note: See TracTickets for help on using tickets.