Remove .torrent doesn't work on watchdir

[rb07]

The preference setting doesn't have the effect expected when the options panel is not used.

The remove .torrent file logic is all in the Options and FileAdded? classes, the signal 'executed' is probably sent from Session, but there is no FileAdded? object to catch it.

To test:

• Preference "auto. add torrents from" enabled and set.
• Preference "remove .torrent" set.
• Preference "start when added" set.
• Preference "show options dialog" not set.

Add a .torrent file to the watch directory.

Result: torrent is added, but the file is not deleted.

[rb07]

Fixed with the attached patch.

Corrections to the description:

• This is with a local session.
• The "start when added" preference is irrelevant.

[rb07]

Hold on, I seem to have broken all .torrent file deletions, except those on the watchdir.

[rb07]

Nope, I didn't break anything, its the same bug I was fixing but in a different place (TrMainWindow::addTorrent with no Options panel has no FileAdded object to do the removing).

I'll post a new patch (fixing both bugs) later, after I test the changes.

[jordan]

rb07, the new code in app.cc and mainwin.cc look very similar to each other and to the code in options.cc, at least superficially. Do you think it make sense to extract any of it into a standalone function that all three blocks could use?

[rb07]

Jordan, Yes (I even copied the comment ;-), I was thinking along the same line, maybe push the functionality into the Session class?

I don't think it is straightforward, but looks like it could be the common point in the execution flow (only Options goes directly to libtransmission, doing something very similar to Session::addTorrent, but with more parameters sent... and I already started by adding the tag parameter).

[jordan]

Session is probably the right place for this. Do you want to take the first shot at it? :)

[rb07]

Change pushed into Session

[rb07]

Replying to jordan:

Session is probably the right place for this. Do you want to take the first shot at it? :)

Done.

[rb07]

Compact and optimized.

[mike.dld]

Thanks, committed as r14349. Some modifications were required though (things changed in 2 years) and I optimized it a bit as well.