Crash on trying to open first torrent file (Transmission compiled for Nokia 770, GTK 2.6.10)

[serge]

When trying to open the first torrent file, Transmission crashes with the following error message displayed in console:

transmission[4596]: GLIB ERROR default - file tr_torrent.c: line 141 (tr_torrent_stat): assertion failed: (TR_IS_TORRENT(tor))

Quick investigation shows that it comes here from 'formatname' function which gets invalid empty data (including 'gtor' pointer) after a call to:

gtk_tree_model_get( model, iter, MC_NAME, &name, MC_STAT, &status,

MC_ERR, &err, MC_SIZE, &size, MC_ETA, &eta, MC_PEERS, &tpeers, MC_UPEERS, &upeers, MC_DPEERS, &dpeers, MC_TORRENT, &gtor, -1 );

Apparently this is caused by 'tr_core_insert' function initially adding empty row and filling it with data a few code lines later (probably empty row attempts to get displayed somehow immediately after its addition). Using more atomic function 'gtk_list_store_insert_with_values' fixes this problem. A patch is attached.

[charles]

committed in r4035. thanks for tracking it down and submitting the patch!