Opened 10 years ago

Closed 10 years ago

#5165 closed Bug (fixed)

Revision 13630... oops!

Reported by: rb07 Owned by: jordan
Priority: Normal Milestone: 2.80
Component: libtransmission Version: 2.74
Severity: Normal Keywords:
Cc:

Description

libtransmission/utils.c:985 :

  • "-_.!~*'()" /* mark */

+ "-_.!~*' ()" /* mark */

Revert this change, please.

Change History (6)

comment:1 Changed 10 years ago by rb07 

-        "-_.!~*'()"                  /* mark */
+        "-_.!~*' ()"                  /* mark */

comment:2 Changed 10 years ago by rb07

Another one...

libtransmission/bencode.c:(1117, 1716, 1731, 1736, too many to list but all similar) 

-                    tr_err( "%s", _( "Invalid metadata" ) );
+                    tr_err ("%s", _ ("Invalid metadata"));

Replace the "_ (" with "_("

comment:3 Changed 10 years ago by rb07

  • Summary changed from Revision 13625... oops! to Revision 13630... oops!

#13625 introduced the mistakes, I was checking (all the conflicts on my source tree w.r.t.) #13630.

Last edited 10 years ago by rb07 (previous) (diff)

comment:4 Changed 10 years ago by jordan

  • Milestone None Set deleted
  • Resolution set to fixed
  • Status changed from new to closed

whoo.

Fixed in r13631

comment:5 Changed 10 years ago by rb07

  • Resolution fixed deleted
  • Status changed from closed to reopened

One I missed for a long time: 

Index: qt/formatter.cc
===================================================================
--- qt/formatter.cc     (revision 14055)
+++ qt/formatter.cc     (working copy)
@@ -172,10 +194,10 @@
   minutes = (seconds % 3600) / 60;
   seconds %= 60;

-  d = tr ("%Ln day (s)", 0, days);
-  h = tr ("%Ln hour (s)", 0, hours);
-  m = tr ("%Ln minute (s)", 0, minutes);
-  s = tr ("%Ln second (s)", 0, seconds);
+  d = tr ("%Ln day(s)", 0, days);
+  h = tr ("%Ln hour(s)", 0, hours);
+  m = tr ("%Ln minute(s)", 0, minutes);
+  s = tr ("%Ln second(s)", 0, seconds);

   if (days)
     {

comment:6 Changed 10 years ago by jordan

  • Milestone set to 2.80
  • Resolution set to fixed
  • Status changed from reopened to closed
  • Version changed from 2.73+ to 2.74

Fixed in r14058

Note: See TracTickets for help on using tickets.