Add borders instead of shadow on scrolled window

[nagisa]

A purely cosmetic change proposal:

Instead of adding a shadow with gtk_scrolled_window_set_shadow_type(GTK_SCROLLED_WINDOW (w), GTK_SHADOW_IN); in gtk/tr-window.c, I propose using CSS styling available from GTK+3 and adding borders on scrolled window using following styles:

border-style: solid;
border-size: 1px 0;

Comparison screen shots of how transmission looks now (note the ugly double border on both sides) and how transmission should look after proposed are attached.

[nagisa]

Current look

[nagisa]

Look after proposed change

[jordan]

current behavior behavior (shadows in the scrolled window)

[jordan]

behavior in ticket-5190-rev-001.diff: remove the shadows, add horizontal separators between the torrent list and the widgets above/below

[jordan]

possible fix

[jordan]

I think we can fix this by removing the shadows altogether and adding horizontal separators between the torrent list and the widgets above & below it. The result looks the same and is a cleaner approach than changing the CSS.

nagisa, any opinion on this?

[nagisa]

Glade mockup with horizontal separators in adwaita. Note that separator above white area is barely visible.

[nagisa]

Glade mockup made to produce earlier screenshot.

[nagisa]

Yes, that's another solution. Result looks good, but I disagree that it does look the same as with CSS – separator styling depends on theme and for example in Adwaita separator is much lighter than regular borders. I suspect this may be a case for several other themes as well.

[jordan]

Okay, TBH this is my first exposure to mixing CSS rules into GTK at the application level. Do you want to cook up a patch for how to do this in the code?

[nagisa]

Sure. I'll just need to figure where to put a stylesheet. You don't seem to have any other data which would require to creating a separate data directory (like /usr/share/transmission/) for it yet.

Making custom stylesheets work is mostly just gtk_style_context_add_provider() away for a single widget or gtk_style_context_add_provider_for_screen() away for all widgets.

[nagisa]

A patch

[nagisa]

Apparently after making a patch I realized I've made a mistake while filling this bug. It is impossible to add border without having a shadow on.

After that it's just shadow styling, which is mostly just hiding a shadow on both sides and leaving it intact on the top and the bottom.

[jordan]

nagisa, does the patch need to be updated for the problem you described in comment:6?

[nagisa]

jordan, no, patch already accounts for it and doesn't remove the shadow, just adds styling to it. It can be merged.

[jordan]

Cool, thanks.

r13822: (gtk) #5190 'Add borders instead of shadow on scrolled window': fixed, patch by nagisa