Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5191 closed Bug (fixed)

Using only a web seed does not update the remaining time

Reported by: Teak Owned by: jordan
Priority: Normal Milestone: 2.76
Component: libtransmission Version: 2.75
Severity: Minor Keywords: web seed time
Cc:

Description

When a download has no peers and only a web seed, the remaining time is not set...

(Only tested on the Mac client)

Attachments (2)

web seed only.png (32.7 KB) - added by Teak 8 years ago.
screenshot
remaingTimeTestWebseed.torrent (20.3 KB) - added by cfpp2p 8 years ago.
remaining time webseed test torrent

Download all attachments as: .zip

Change History (16)

Changed 8 years ago by Teak

screenshot

comment:1 Changed 8 years ago by livings124

  • Component changed from Mac Client to libtransmission
  • Owner changed from livings124 to jordan

comment:2 follow-up: Changed 8 years ago by cfpp2p

this looks like duplicate of #5063

comment:3 in reply to: ↑ 2 Changed 8 years ago by x190

Replying to cfpp2p:

this looks like a duplicate of #5063

...which did not fix the 'remaining time' issue where a webseed is the only 'peer' supplying data. #5063 has a good test torrent.

Last edited 8 years ago by x190 (previous) (diff)

comment:4 Changed 8 years ago by cfpp2p

in the big fiasco of #5063, #5081, and #5069 I forgot to share part of the patch I use. This fixes the remaining time even with only webseed(s) as peers.

at current trunk torrent.c line 1259 change FROM:

if (s->leftUntilDone > s->desiredAvailable)

TO:

if( (s->leftUntilDone > s->desiredAvailable) && (tor->info.webseedCount < 1) )

I've been using this for months now. It fixes the problem that tr_peerMgrGetDesiredAvailable() doesn't include webseeds.

you'll need to use a torrent WITHOUT any peers. The torrent of #5063 has peers sometimes. I've attached a test torrent.

Last edited 8 years ago by cfpp2p (previous) (diff)

Changed 8 years ago by cfpp2p

remaining time webseed test torrent

comment:5 Changed 8 years ago by Teak

I've also just noticed that the speed limits don't seem to have an effect on the web seed...

Does this patch also fix that?

comment:6 Changed 8 years ago by cfpp2p

I've also just noticed that the speed limits don't seem to have an effect on the web seed...

Does this patch also fix that?

It doesn't. See #1079

comment:7 Changed 8 years ago by jordan

  • Milestone changed from None Set to 2.80
  • Status changed from new to assigned
  • Version changed from 2.75+ to 2.75

Fixed with cfpp2p's patch in r13688.

comment:8 follow-up: Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:9 Changed 8 years ago by x190

From r13688: if ((s->leftUntilDone > s->desiredAvailable) && (tor->info.webseedCount < 0))
webseedCount < 0---when's that going to be true???

cfpp2p's patch: if( (s->leftUntilDone > s->desiredAvailable) && (tor->info.webseedCount < 1) )

Last edited 8 years ago by x190 (previous) (diff)

comment:10 in reply to: ↑ 8 Changed 8 years ago by x190

Replying to jordan:

Surely, you meant to use cfpp2p's patch verbatim or else remove the now dead code!

Last edited 8 years ago by x190 (previous) (diff)

comment:11 Changed 8 years ago by x190

  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:12 Changed 8 years ago by jordan

You know, if tr_info.trackerCount and tr_info.webseedCount were unsigned, the compiler would warn about this... :)

comment:13 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

Fixed r13722.

comment:14 Changed 8 years ago by jordan

  • Milestone changed from 2.80 to 2.76
Note: See TracTickets for help on using tickets.