Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#5204 closed Bug (fixed)

mp4, mkv files are not shown with the video-x-generic icon

Reported by: jordan Owned by: jordan
Priority: Normal Milestone: 2.76
Component: Qt Client Version: 2.75
Severity: Normal Keywords:
Cc:

Description

A typo in Utils::guessMimeIcon() is preventing these two filetypes from being guessed correctly.

Change History (5)

comment:1 Changed 9 years ago by jordan

  • Status changed from new to assigned

comment:2 Changed 9 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Fixed in r13728.

comment:3 Changed 9 years ago by rb07

  • Resolution fixed deleted
  • Status changed from closed to reopened

Still has mov twice:

+<<<<<<< .mine
+            "3gp", "asf", "avi", "mkv", "mov", "mp4", "mpeg", "mpg",
+=======
+            "3gp", "asf", "avi", "mov", "mpeg", "mpg", "mp4", "mkv", "mov",
+>>>>>>> .r13728

Doesn't have xz (which is becoming common):

-            "7z", "ace", "bz2", "cbz", "gz", "gzip", "lzma", "rar", "sft", "tar", "zip" };
+            "7z", "ace", "bz2", "cbz", "gz", "gzip", "lzma", "rar", "sft", "tar", "xz", "zip" };

And uses the deprecated QString::fromAscii() all over the place (and non-existent in Qt5, which recommends using fromLatin1).

comment:4 Changed 9 years ago by jordan

  • Resolution set to fixed
  • Status changed from reopened to closed

Nice catches; added in r13730.

comment:5 Changed 9 years ago by jordan

  • Milestone changed from 2.80 to 2.76
Note: See TracTickets for help on using tickets.