Opened 9 years ago
Closed 9 years ago
#5212 closed Bug (fixed)
cli fails when Downloads directory doesn't exist
| Reported by: | jordan | Owned by: | jordan |
|---|---|---|---|
| Priority: | Normal | Milestone: | 2.76 |
| Component: | CLI | Version: | 2.75 |
| Severity: | Normal | Keywords: | |
| Cc: |
Description
From downstream ticket at https://bugs.launchpad.net/ubuntu/+source/transmission/+bug/1029066:
When using transmission-cli on a command line server, such as the Ubuntu cloud images, the Downloads directory doesn't exist, and the transmission-cli tool just fails. It should try to make the directory instead.
Change History (4)
comment:1 Changed 9 years ago by jordan
- Milestone changed from None Set to 2.76
- Owner set to jordan
- Status changed from new to assigned
comment:2 Changed 9 years ago by jordan
comment:3 Changed 9 years ago by jordan
Fixed in r13764.
comment:4 Changed 9 years ago by jordan
- Resolution set to fixed
- Status changed from assigned to closed
Note: See
TracTickets for help on using
tickets.
Dustin's also got a decent patch for this, but looking at the CLI code, I'm not sure what the original motivation was for calling realpath() on the download dir was -- neither the daemon nor transmission-gtk do that.
IMO it would be more consistent to just use the user-specified download directory as-is, just as the other flavors of transmission do, and avoid that realpath() call altogether. Since CLI uses realpath()'s side effect of testing whether or not the directory exists, we'll need to redo that test, such as with a call to tr_fileExists().