#5214 closed Enhancement (fixed)
Add storage free space indicator
Reported by: | taem | Owned by: | jordan |
---|---|---|---|
Priority: | Normal | Milestone: | 2.80 |
Component: | Web Client | Version: | 2.76 |
Severity: | Normal | Keywords: | patch |
Cc: |
Description
Hi,
Please find attached proposed patch that adds storage free space indicator.
Thanks.
Attachments (2)
Change History (18)
Changed 9 years ago by taem
comment:1 Changed 9 years ago by taem
comment:2 Changed 9 years ago by jordan
- Milestone changed from None Set to 2.80
- Owner set to jordan
- Status changed from new to assigned
comment:3 Changed 9 years ago by jordan
- Resolution set to fixed
- Status changed from assigned to closed
Added in r13884.
comment:4 Changed 9 years ago by livings124
- Resolution fixed deleted
- Status changed from closed to reopened
Same as #4076, there should be context to what this number represents. Perhaps it should also be moved to the bottom-right.
comment:5 follow-up: ↓ 7 Changed 9 years ago by jordan
That's a good idea.
Taem, could you update the patch to add "Free" to the end and to move the label to the bottom right?
comment:6 Changed 9 years ago by rb07
In Transmission-Qt what was moved to the right is the ratio, not the free space. I like the idea of free space on the right better.
Shouldn't the Web client look about the same?
Changed 9 years ago by taem
comment:7 in reply to: ↑ 5 Changed 9 years ago by taem
Replying to jordan:
Taem, could you update the patch to add "Free" to the end and to move the label to the bottom right?
Please find attached patch. I hope a patch is ok. I have a little knowledge of CSS :)
comment:8 Changed 9 years ago by jordan
- Resolution set to fixed
- Status changed from reopened to closed
looks good to me.
Patched in r13977.
comment:9 Changed 9 years ago by jordan
- Resolution fixed deleted
- Status changed from closed to reopened
We should modify this to show freespace in the Add Torrent popup.
comment:10 Changed 9 years ago by jordan
- Resolution set to fixed
- Status changed from reopened to closed
comment:11 Changed 9 years ago by lucke
Be it PEBKAC or not? I'm running r14009, transmission-daemon's webclient shows the indicator in the statusbar, qtr's webclient shows it in the "Add Torrent" dialog.
comment:12 Changed 9 years ago by jordan
Try flushing your browser cache... probably PEBKAC ;)
comment:13 Changed 9 years ago by lucke
Forced reload of the page made it right.
comment:14 Changed 9 years ago by killemov
- Resolution fixed deleted
- Status changed from closed to reopened
Confused. In r14009 the message is to restore the RPC download-dir-free-space argument. The removal of that argument, IF the argument should be removed at all, should be for a major version update and that would be 3.0.
comment:15 Changed 9 years ago by jordan
- Resolution set to fixed
- Status changed from reopened to closed
No, I disagree. Major versions come around very very rarely for Transmission, so I'm not going to wait that long. 1.0 came out in Jan 2008, 2.0 came out in Jun 2010, and we probably won't see 3.0 until >= 2014.
r14009 is to give notice that this feature is going away s.t. 2.77 doesn't cause immediate breakage. That's a substantially different goal than keeping a feature around for the next year or so.
Hi,
Please find attached updated patch.
Thanks.