Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#5234 closed Bug (fixed)

Typo changed 'lpd-enabled' to 'ldp-enabled' in RPC

Reported by: atomicdryad Owned by: jordan
Priority: Normal Milestone:
Component: libtransmission Version:
Severity: Normal Keywords: typo, rpc, lpd-enabled
Cc:

Description

Apparently this occured @ 13683, it causes transmission-remote-cli to crash, and sturdier rpc clients to lose the ability to get/set lpd-enabled. Pasted diff adds lpd-* instead of replacing ldp-* incase some clients were adjusted to use the latter.

--- ../rpcimpl.c        2013-01-20 01:41:52.000000000 -0600
+++ libtransmission/rpcimpl.c   2013-01-20 01:42:14.000000000 -0600
@@ -1862,6 +1862,7 @@
     tr_variantDictAddBool (d, TR_KEY_utp_enabled, tr_sessionIsUTPEnabled (s));
     tr_variantDictAddBool (d, TR_KEY_dht_enabled, tr_sessionIsDHTEnabled (s));
     tr_variantDictAddBool (d, TR_KEY_ldp_enabled, tr_sessionIsLPDEnabled (s));
+    tr_variantDictAddBool (d, TR_KEY_lpd_enabled, tr_sessionIsLPDEnabled (s));
     tr_variantDictAddInt  (d, TR_KEY_peer_port, tr_sessionGetPeerPort (s));
     tr_variantDictAddBool (d, TR_KEY_peer_port_random_on_start, tr_sessionGetPeerPortRandomOnStart (s));
     tr_variantDictAddBool (d, TR_KEY_port_forwarding_enabled, tr_sessionIsPortForwardingEnabled (s));

Change History (3)

comment:1 Changed 8 years ago by jordan

  • Milestone None Set deleted
  • Status changed from new to assigned
  • Version 2.76 deleted

comment:2 Changed 8 years ago by jordan

  • Resolution set to fixed
  • Status changed from assigned to closed

Thanks for reporting this... I've added some unit tests to smoke out any future typos :)

r13814: add unit test (currently failing) to test for this issue

r13815: add a fix, which causes r13814's test to pass

comment:3 Changed 8 years ago by jordan

r13816:remove the typo'ed quark to avoid future confusion

Note: See TracTickets for help on using tickets.