#5285 closed Enhancement (fixed)
Qt client's file tree should have a size column like the GTK+ client has
Reported by: | jordan | Owned by: | jordan |
---|---|---|---|
Priority: | Normal | Milestone: | 2.80 |
Component: | Qt Client | Version: | 2.76 |
Severity: | Normal | Keywords: | |
Cc: | nikoli@… |
Description
This is more useful now that we're adding a Free Space indicator into the "Add a Torrent" dialog (#4076) and showing the size wanted, rather than the total size of the torrent, in the file tree (#5284).
In short, it's useful to at-a-glance compare the space free with the space needed by the selected files.
Since the size is currently listed parenthetically next to the filename in the Name column, it's easy for this size to be obscured if the name is longer than the column is wide, causing truncation.
Change History (5)
comment:1 Changed 10 years ago by jordan
- Milestone changed from None Set to 2.80
- Status changed from new to assigned
comment:2 Changed 10 years ago by jordan
- Resolution set to fixed
- Status changed from assigned to closed
comment:3 Changed 10 years ago by rb07
- Resolution fixed deleted
- Status changed from closed to reopened
A side effect of this change sends guessMimeIcon() a truncated file name (when the file name has a space-parent, which was truncated before because it used to be the size value).
Patch:
Index: qt/file-tree.cc =================================================================== --- qt/file-tree.cc (revision 14072) +++ qt/file-tree.cc (working copy) @@ -813,7 +813,7 @@ else { QString name = index.data().toString(); - icon = Utils :: guessMimeIcon (name.left(name.lastIndexOf(" ("))); + icon = Utils :: guessMimeIcon (name); } icon.paint (painter, iconArea, Qt::AlignCenter, QIcon::Normal, QIcon::On);
comment:4 Changed 10 years ago by jordan
- Resolution set to fixed
- Status changed from reopened to closed
Great catch, thank you rb07.
Patched in r14073.
comment:5 Changed 10 years ago by Nikoli
- Cc nikoli@… added
Added in r14000.